Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to RN 0.66 #4235

Merged
merged 50 commits into from
Jan 3, 2022
Merged

Upgrade to RN 0.66 #4235

merged 50 commits into from
Jan 3, 2022

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Nov 11, 2021

Related PRs

Description

Upgrade React Native to 0.66. See the React Native Upgrade Helper for additional details.

To test: See WordPress/gutenberg#36328.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@dcalhoun dcalhoun added dependencies Pull requests that update a dependency file [Type] Task labels Nov 11, 2021
@dcalhoun dcalhoun self-assigned this Nov 11, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 12, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@hypest hypest force-pushed the chore/upgrade-to-react-native-0.66 branch from d100ec7 to fb7e0ec Compare November 12, 2021 18:00
@hypest
Copy link
Contributor

hypest commented Nov 15, 2021

I will test out the full manual testsuite for WPAndroid:

  • Device: Pixel 2XL : Android 11
  • Build: RP1A.201005.004.A1

🟢 Writing Flow

General

  • TC001 - Paste formatted text copied from website. Looks like the "Join Us" image is not copied anymore, the web page has changed compared to way back.
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph (failing as expected due to issue on Android)
    • Heading (failing as expected due to issue on Android)
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text. The undo removes all words that I inputted in a consecutive typing action. Redo reinstated all in one ago as well.
  • TC003 - Undo/redo text format

🟢 Unsupported Block Editor

  • TC001 User can edit unsupported blocks on Simple WP.com sites
  • TC002 User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites. (Not RN related so, skipping)
  • TC004 Editing unsupported blocks is disallowed on Classic-enabled Atomic sites. (Not RN related so, skipping)
  • TC005 Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack. (Not RN related so, skipping)
  • TC006 Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password. (Not RN related so, skipping)

🟢 Sanity Tests (Test Suite 1)

Gallery - 1

  • Gallery block - Close/Re-open post with an ongoing image upload - TC001
  • Gallery block - Close post with an ongoing image upload - TC002

Gallery - 2

  • Gallery block - Insert image from device (failing) - TC006
  • Gallery block - Insert image from device (cancel) - TC009

Gallery - 3

  • Gallery block - Add Gallery Caption - TC003
  • Gallery block - Add Gallery Image Caption - TC04
  • Gallery block - Try adding same images from WP Media library and moving the images around - TC010

Columns - 1

  • Columns - Columns percentage mechanism - column's preview - TC019
  • Columns - Columns percentage mechanism - column's slider input - TC020
  • Columns - Columns percentage mechanism - predefined percentage values are rendered correctly on frontend- TC021. Only tried the 30/70 layout option.
  • Columns percentage mechanism - custom percentage values are rendered correctly on frontend- TC022
  • Columns - Multiple slider in columns parent - TC023
  • Columns - Adding Column with AppenderButton - TC003
  • Columns - Adding and removing Column with BottomSheet Stepper control - TC004

Columns - 2

  • Columns - Max limit of Column number - TC005
  • Columns - Min limit of Column number - TC006
  • Columns - Removing Column with remove button - TC007
  • Columns - Removing the only one left Column with remove button - TC008
  • Columns - Changing alignment on Columns - TC009
  • Columns - Changing alignment on individual Column - TC010
  • Columns - Alignment attribute is properly passed when adding Column - TC011
  • Columns - Deep nesting is possible (iOS only)- TC012. Didn't crash on Android either.

Columns - 3

  • Columns - Check if Column placeholders is visible for the unselected state - TC002
  • Columns - Appearance in vertical device position (vertical layout) - TC013
  • Columns - Appearance in horizontal device position (horizontal layout) - TC014
  • Columns - Mover direction - TC015
  • Columns - Check if Column placeholder is render in nested structure - TC016
  • Columns - Unselected Column placeholder is stretched to content in nested structure- TC017

MediaText - 1

  • Media Text block - Insert image from device (failing) - TC001
  • Media Text block - Close/Re-open post with an ongoing image upload - TC003

MediaText - 2

  • Media Text block - Insert video from device (TC002) - steps
  • Media Text block - Insert image from device (TC002) - steps

MultipleUpload - 1

  • Simultaneous uploads - TC001

Cover - 1

  • Cover - Add image background from WordPress Media library - TC001
  • Cover - Change Minimum height in pixels - TC002
  • Cover - Change Background Opacity - TC009
  • Cover - Image focal point is rendered properly - TC003
  • Cover - Custom color is rendered properly - TC004

Editor Theme - 1

  • Default Colors - Check that default colors still load - TC001
  • Default Gradients - Check that default gradients still load - TC002
  • Custom Colors - Check that custom colors load in the editor - TC003

Social Icons - 1

  • The newly created Social Icons block is added with 4 icons - TC001
  • Active icon gets product color - TC002
  • Only active icons are visible when not selected - TC003

🟢 Sanity Tests (Test Suite 2)

DarkMode - 1

  • Gallery block - Dark mode - TC001
  • Shortcode block - Dark mode - TC002
  • Media Text block - Dark mode - TC003

Group - 1

  • Group - AppenderButton is rendered - TC001
  • Group - Deep nesting is possible (iOS only) - TC002
  • Group - Check if Group placeholder is visible for the unselected state - TC003
  • Group - Check if Group placeholder is render in nested structure - TC004
  • Group - Nested block have proper border styling - TC005
  • Group - Nested block have proper margins values - TC006. Well, they are visually exactly the same as the production app so, I count this is ✅
  • Group - Breadcrumbs on FloatingToolbar is properly displayed - TC008. Same behavior as in production app.

Spacer - 1

  • Spacer block - Spacer is rendered without crash - TC001
  • Spacer block - Settings: Control spacer height using the slider - TC002
  • Spacer block - Settings: Control spacer height using the text input - TC003

Buttons-1

  • Buttons block - Buttons block is added with focused Button with gray background color and white text color - TC001
  • Buttons block - Buttons inline appender - TC002
  • Buttons block - Add another Button inside Buttons using inserter - TC003
  • Buttons block - Button's wrapper grows properly - TC023

Buttons-2

  • Buttons block - Removing Button along with Buttons block - TC004
  • Buttons block - Removing exactly one Button (when Buttons contain more of them) - TC005

Buttons-3

  • Buttons block - Wrapping Buttons - TC006
  • Buttons block - Buttons alignment options - TC007

Button-6

  • Buttons block - Settings: Open in new tab - TC011
  • Buttons block - Settings: Link rel - TC012
  • Buttons block - Settings: Link URL - TC010
  • Buttons block - Settings: Remove link - TC014
  • Buttons block - Settings: Synchronize with button options - TC013

Color Settings - 1

  • Colors Segmented Controls - TC001
  • Scroll color palette to start - TC002
  • Scroll color palette to the end - TC003

Image - 1

  • Image block - Insert image from device (failing) - TC001
  • Image block - Insert image from device (cancel) - TC002
  • Image block - Add Caption - TC003
  • Image block - Close/Re-open post with an ongoing image upload - TC004
  • Image block - Close post with an ongoing image upload - TC005

🟢 Sanity Tests (Test Suite 3)

Gallery - 2

  • Gallery block - Insert image from device (failing) - TC006
  • Gallery block - Insert image from device (cancel) - TC009

Gallery - 3

  • Gallery block - Add Gallery Caption - TC003
  • Gallery block - Add Gallery Image Caption - TC004
  • Gallery block - Try adding same images from WP Media library and moving the images around - TC010

Gallery - 4

  • Gallery block - Settings: Link to - TC012
  • Gallery block - Settings: Column number - TC013
  • Gallery block - Settings: Crop images - TC014

Columns - 2

  • Columns - Max limit of Column number - steps
  • Columns - Min limit of Column number - steps
  • Columns - Removing Column with remove button - steps
  • Columns - Removing the only one left Column with remove button - steps
  • Columns - Changing alignment on Columns - steps
  • Columns - Changing alignment on individual Columnn - steps
  • Columns - Alignment attribute is properly passed when adding Column - steps
  • Columns - Deep nesting is possible (iOS only)- steps

Columns - 3

  • Columns - Check if Column placeholders is visible for the unselected state - steps
  • Columns - Appearance in vertical device position (vertical layout) - steps
  • Columns - Appearance in horizontal device position (horizontal layout) - steps
  • Columns - Mover direction - steps
  • Columns - Check if Column placeholder is render in nested structure - steps
  • Columns - Unselected Column placeholder is streched to content in nested structure- steps

Columns - 4

  • Columns - Check if in DarkMode all components gets proper colors - steps

MediaText - 3

  • Media Text block - Insert video from device (failing) - TC001-v
  • Media Text block - Close/Re-open post with an ongoing video upload - TC003-v

MediaText - 4

  • Media Text block - Media & Text alignment - TC006
  • Media Text block - Vertical alignment - TC007

Shortcode-1

  • Shortcode block - Add a youtube link - steps

Cover - 2

  • Cover - Add Video Background from WordPress Media library - TC005
  • Cover - Replace media - TC006
  • Cover - Gradient background is rendered properly - TC007
  • Cover - Gradient overlay is rendered properly - TC008

Social Icons - 2

  • The link sheet is opened automatically when adding new icon - TC004
  • Ghost placeholder is visible when no icon is active - TC005
  • Social icon forwarding to the link - TC006

Image - 2

  • Image block - Border style setting - TC006
  • Image block - Image size setting - TC007
  • Image block - Link to setting - TC008

Story block - 1

  • Story block - Verify is available in Block Picker - TC001
  • Story block - Verify is not available in Block Picker- TC002
  • Story block - Add media to empty Story block - TC003
  • Story block - Add media to non-empty Story block - TC004
  • Story block - Close/Re-open post with an ongoing Story upload - TC005

@twstokes
Copy link
Contributor

twstokes commented Dec 1, 2021

Running the full manual testsuite for WPiOS:

  • Device: iPhone 12: iOS 15
  • Build: 62265

🟢 Writing Flow

General

  • TC001 - Paste formatted text copied from website. Looks like the "Join Us" image is not copied anymore, the web page has changed compared to way back.
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph (failing as expected due to issue on Android)
    • Heading (failing as expected due to issue on Android)
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text. The undo removes all words that I inputted in a consecutive typing action. Redo reinstated all in one ago as well.
  • TC003 - Undo/redo text format

Unsupported Block Editor

  • TC001 User can edit unsupported blocks on Simple WP.com sites
  • TC002 User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites. (Not RN related so, skipping)
  • TC004 Editing unsupported blocks is disallowed on Classic-enabled Atomic sites. (Not RN related so, skipping)
  • TC005 Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack. (Not RN related so, skipping)
  • TC006 Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password. (Not RN related so, skipping)

🟢 Sanity Tests (Test Suite 1)

Gallery - 1

  • Gallery block - Close/Re-open post with an ongoing image upload - TC001
  • Gallery block - Close post with an ongoing image upload - TC002

Gallery - 2

  • Gallery block - Insert image from device (failing) - TC006
  • Gallery block - Insert image from device (cancel) - TC009

Gallery - 3

  • Gallery block - Add Gallery Caption - TC003
  • Gallery block - Add Gallery Image Caption - TC004
  • Gallery block - Try adding same images from WP Media library and moving the images around - TC010

Columns - 1

  • Columns - Columns percentage mechanism - column's preview - TC019
  • Columns - Columns percentage mechanism - column's slider input - TC020
  • Columns - Columns percentage mechanism - predefined percentage values are rendered correctly on frontend- TC021.
  • Columns percentage mechanism - custom percentage values are rendered correctly on frontend- TC022
  • Columns - Multiple slider in columns parent - TC023
  • Columns - Adding Column with AppenderButton - TC003
  • Columns - Adding and removing Column with BottomSheet Stepper control - TC004

Columns - 2

  • Columns - Max limit of Column number - TC005
  • Columns - Min limit of Column number - TC006
  • Columns - Removing Column with remove button - TC007
  • Columns - Removing the only one left Column with remove button - TC008
  • Columns - Changing alignment on Columns - TC009
  • Columns - Changing alignment on individual Column - TC010
  • Columns - Alignment attribute is properly passed when adding Column - TC011
  • Columns - Deep nesting is possible (iOS only)- TC012. Didn't crash on Android either.

Columns - 3

  • Columns - Check if Column placeholders is visible for the unselected state - TC002
  • Columns - Appearance in vertical device position (vertical layout) - TC013
  • Columns - Appearance in horizontal device position (horizontal layout) - TC014
  • Columns - Mover direction - TC015
  • Columns - Check if Column placeholder is render in nested structure - TC016
  • Columns - Unselected Column placeholder is stretched to content in nested structure- TC017

MediaText - 1

  • Media Text block - Insert image from device (failing) - TC001
  • Media Text block - Close/Re-open post with an ongoing image upload - TC003

MediaText - 2

  • Media Text block - Insert video from device (TC002) - steps
  • Media Text block - Insert image from device (TC002) - steps

MultipleUpload - 1

  • Simultaneous uploads - TC001

Cover - 1

  • Cover - Add image background from WordPress Media library - TC001
  • Cover - Change Minimum height in pixels - TC002
  • Cover - Change Background Opacity - TC009 (fixed with this commit)
  • Cover - Image focal point is rendered properly - TC003
  • Cover - Custom color is rendered properly - TC004

Editor Theme - 1

  • Default Colors - Check that default colors still load - TC001
  • Default Gradients - Check that default gradients still load - TC002
  • Custom Colors - Check that custom colors load in the editor - TC003

Social Icons - 1

  • The newly created Social Icons block is added with 4 icons - TC001
  • Active icon gets product color - TC002
  • Only active icons are visible when not selected - TC003

@dcalhoun
Copy link
Member Author

dcalhoun commented Dec 2, 2021

  • Device: Samsung Galaxy S20 (Android 11)
  • Build: 117413

🟡 Writing Flow

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
      • 🟡 It requires 3 instead of the expected 2 Delete key presses to complete this scenario. The first press seemingly transforms the Heading to a Paragraph. (Issue 1, Issue 2)
      • 🟡 Transforming a Paragraph block to a Heading results in incorrect line height. (Issue)
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

🟢 Unsupported Block Editor

  • TC001 User can edit unsupported blocks on Simple WP.com sites
  • TC002 User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

🟡 Sanity Tests (Test Suite 4)

DarkMode - 2

  • Spacer block - Dark mode - TC004
  • Buttons block - Dark mode - TC005
  • Group - Dark mode - TC006
  • Columns - Dark mode - TC007

Group - 2

  • Group - Navigation up button works as expected - TC009
  • Group - Navigation down works according to parent-first approach - TC010
  • Group - Cross navigation between blocks works as expected - TC011
  • Group - Ungroup button works as expected - TC012
  • Group - Check if in DarkMode all components gets proper colors - TC013
    • 🟡 Group block contents do not update when toggling Dark Mode (Issue)
  • Group - Check if nested Placeholder block can be replaced - TC014

Spacer - 2

  • Spacer block - Settings: Available height range is correct - TC004
  • Spacer block - Settings: Height range extends if Spacer comes from the web is higher than 500px - TC005
  • Spacer block - Spacer in horizontal layout works as expected - TC006

Buttons - 4

  • Buttons block - Render custom text color - TC017
  • Buttons block - Render custom background color - TC016
  • Buttons block - Render gradient background color - TC018
  • Buttons block - Check if selection / caret color matches font color - TC020
  • Buttons block - The newly created Buttons has set background color to the theme-default color in preview - TC021

Buttons - 5

  • Buttons block - Edit text styles - TC009
  • Buttons block - Render theme colors - TC019
  • Buttons block - Settings: Change Button border radius - TC015

Buttons - 7

  • Buttons block - Link from the clipboard is automatically added into the empty URL field in link settings and button options - TC008
  • Buttons block - Toolbar link button is active when Button has link - TC022

Editor Theme - 2

  • Custom Gradients - Check that custom gradients load in the editor - TC004
  • Offline Support - TC005

Color Settings - 2

  • Pressing color swatch - TC004
  • Customize gradient color - TC005
  • Custom color picker - TC006

@dcalhoun dcalhoun marked this pull request as ready for review December 6, 2021 23:13
@dcalhoun
Copy link
Member Author

dcalhoun commented Dec 7, 2021

🟢 Sanity Tests (Test Suite 2) @twstokes

  • Device: iPhone 12 mini (iOS 15.1.1)
  • Build: 62279

DarkMode - 1

  • Gallery block - Dark mode - TC001
  • Shortcode block - Dark mode - TC002
  • Media Text block - Dark mode - TC003

Group - 1

  • Group - AppenderButton is rendered - TC001
  • Group - Deep nesting is possible (iOS only) - TC002
  • Group - Check if Group placeholder is visible for the unselected state - TC003
  • Group - Check if Group placeholder is render in nested structure - TC004
  • Group - Nested block have proper border styling - TC005
  • Group - Nested block have proper margins values - TC006
  • Group - Breadcrumbs on FloatingToolbar is properly displayed - TC008

Spacer - 1

  • Spacer block - Spacer is rendered without crash - TC001
  • Spacer block - Settings: Control spacer height using the slider - TC002
  • Spacer block - Settings: Control spacer height using the text input - TC003

Buttons-1

  • Buttons block - Buttons block is added with focused Button with gray background color and white text color - TC001
  • Buttons block - Buttons inline appender - TC002
  • Buttons block - Add another Button inside Buttons using inserter - TC003
  • Buttons block - Button's wrapper grows properly - TC023

Buttons-2

  • Buttons block - Removing Button along with Buttons block - TC004
  • Buttons block - Removing exactly one Button (when Buttons contain more of them) - TC005

Buttons-3

  • Buttons block - Wrapping Buttons - TC006
  • Buttons block - Buttons alignment options - TC007

Button-6

  • Buttons block - Settings: Open in new tab - TC011
  • Buttons block - Settings: Link rel - TC012
  • Buttons block - Settings: Link URL - TC010
  • Buttons block - Settings: Remove link - TC014
  • Buttons block - Settings: Synchronize with button options - TC013

Color Settings - 1

  • Colors Segmented Controls - TC001
  • Scroll color palette to start - TC002
  • Scroll color palette to the end - TC003

Image - 1

  • Image block - Insert image from device (failing) - TC001
  • Image block - Insert image from device (cancel) - TC002
  • Image block - Add Caption - TC003
  • Image block - Close/Re-open post with an ongoing image upload - TC004
  • Image block - Close post with an ongoing image upload - TC005

🟡 Sanity Tests (Test Suite 3)

  • Device: iPhone 13 mini (iOS 15.1.1)
  • Build: 62279

Gallery - 2

  • Gallery block - Insert image from device (failing) - TC006
  • Gallery block - Insert image from device (cancel) - TC009

Gallery - 3

  • Gallery block - Add Gallery Caption - TC003
  • Gallery block - Add Gallery Image Caption - TC004
  • Gallery block - Try adding same images from WP Media library and moving the images around - TC010

Gallery - 4

Columns - 2

  • Columns - Max limit of Column number - steps
  • Columns - Min limit of Column number - steps
  • Columns - Removing Column with remove button - steps
  • Columns - Removing the only one left Column with remove button - steps
  • Columns - Changing alignment on Columns - steps
  • Columns - Changing alignment on individual Columnn - steps
  • Columns - Alignment attribute is properly passed when adding Column - steps
  • Columns - Deep nesting is possible (iOS only)- steps

Columns - 3

  • Columns - Check if Column placeholders is visible for the unselected state - steps
  • Columns - Appearance in vertical device position (vertical layout) - steps
  • Columns - Appearance in horizontal device position (horizontal layout) - steps
  • Columns - Mover direction - steps
  • Columns - Check if Column placeholder is render in nested structure - steps
  • Columns - Unselected Column placeholder is streched to content in nested structure- steps

Columns - 4

  • Columns - Check if in DarkMode all components gets proper colors - steps

MediaText - 3

  • Media Text block - Insert video from device (failing) - TC001-v
  • Media Text block - Close/Re-open post with an ongoing video upload - TC003-v

MediaText - 4

  • Media Text block - Media & Text alignment - TC006
  • Media Text block - Vertical alignment - TC007

Shortcode-1

  • Shortcode block - Add a youtube link - steps

Cover - 2

Social Icons - 2

  • The link sheet is opened automatically when adding new icon - TC004
  • Ghost placeholder is visible when no icon is active - TC005
  • Social icon forwarding to the link - TC006

Image - 2

  • Image block - Border style setting - TC006
  • Image block - Image size setting - TC007
  • Image block - Link to setting - TC008

Story block - 1

  • Story block - Verify is available in Block Picker - TC001
  • Story block - Verify is not available in Block Picker- TC002
  • Story block - Add media to empty Story block - TC003
  • Story block - Add media to non-empty Story block - TC004
  • Story block - Close/Re-open post with an ongoing Story upload - TC005

🟡 Sanity Tests (Test Suite 4)

  • Device: iPhone 13 mini (iOS 15.1.1)
  • Build: 62279

DarkMode - 2

  • Spacer block - Dark mode - TC004
  • Buttons block - Dark mode - TC005
  • Group - Dark mode - TC006
  • Columns - Dark mode - TC007

Group - 2

  • Group - Navigation up button works as expected - TC009
  • Group - Navigation down works according to parent-first approach - TC010
  • Group - Cross navigation between blocks works as expected - TC011
  • Group - Ungroup button works as expected - TC012
  • Group - Check if in DarkMode all components gets proper colors - TC013
  • Group - Check if nested Placeholder block can be replaced - TC014

Spacer - 2

  • Spacer block - Settings: Available height range is correct - TC004
  • Spacer block - Settings: Height range extends if Spacer comes from the web is higher than 500px - TC005
  • Spacer block - Spacer in horizontal layout works as expected - TC006

Buttons - 4

  • Buttons block - Render custom text color - TC017
  • Buttons block - Render custom background color - TC016
  • Buttons block - Render gradient background color - TC018
  • Buttons block - Check if selection / caret color matches font color - TC020
  • Buttons block - The newly created Buttons has set background color to the theme-default color in preview - TC021

Buttons - 5

  • Buttons block - Edit text styles - TC009
  • Buttons block - Render theme colors - TC019
  • Buttons block - Settings: Change Button border radius - TC015

Buttons - 7

  • Buttons block - Link from the clipboard is presented as an option in the link picker - TC008
  • Buttons block - Toolbar link button is active when Button has link - TC022

Editor Theme - 2

  • Custom Gradients - Check that custom gradients load in the editor - TC004
  • Offline Support - TC005

Color Settings - 2

🟡 Sanity Tests (Test Suite 5)

  • Device: iPhone 13 mini (iOS 15.1.1)
  • Build: 62279

Video block - 1

  • Video block - Insert video from device (failing) - steps
  • Video block - Close/Re-open post with an ongoing video upload - steps

Video block - 2

  • Video block - Insert video from device (cancel) - steps
  • Video block - Close post with an ongoing video upload - steps
  • Video block - Add Caption - steps

File block - 1

  • File block - Upload completes successfully from the device library - steps
  • File block - Insert completes successfully from the WordPress Media library - steps
  • File block - Upload fails from the device library - steps
  • File block - Stop the file upload before it completes - steps

File block - 2

  • File block - Close the post with an ongoing file upload - steps
  • File block - Replace the selected files - steps
  • File block - Change the alignment in the File Block - steps
  • File block - The Link To Block Setting should open - steps

File block - 3

  • File block - Open link in new tab - steps
  • File block - Show/hide download button (Block Settings only) - steps
  • File block - Copy file URL - steps
  • File block - Close/Re-open post with an ongoing file upload - steps

Audio block - 1

  • Audio block - Upload completes successfully from the device library - steps
  • Audio block - Insert completes successfully from the WordPress Media library - steps

Audio block - 2

  • Audio block - Upload fails from the device library - steps
  • Audio block - Stop the audio file upload before it completes - steps

Audio block - 3

  • Audio block - Close the post with an ongoing audio file upload - steps
  • Audio block - Replace the selected files - steps
  • Audio block - Change the alignment in the Audio Block - steps

Audio block - 4

  • Audio block - Autoplay setting - steps
  • Audio block - Loop setting - steps
  • Audio block - Close/Re-open post with an ongoing audio file upload - steps

Reusable block - 1

Reusable block - 2

  • Reusable block - Deleted reusable block - steps
  • Reusable block - Recursive block rendering - steps

Embed block - 1

  • Embed block - Inline previews are rendered correctly for the top 5 most-used providers - steps

Embed block - 2

  • Embed block - Inline previews are rendered accordingly for each alignment option - steps

@dcalhoun dcalhoun requested review from twstokes and hypest December 9, 2021 15:59
Result of `npm install` after updating the Gutenberg version.
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Once @twstokes has had a chance to look over the iOS side of things, let's get this shipped! 🚀

Copy link
Contributor

@twstokes twstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the iOS side @dcalhoun. 👍

@dcalhoun dcalhoun enabled auto-merge January 3, 2022 22:02
@dcalhoun dcalhoun merged commit d5f20ac into develop Jan 3, 2022
@dcalhoun dcalhoun deleted the chore/upgrade-to-react-native-0.66 branch January 3, 2022 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file [Type] Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants