-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to RN 0.66 #4235
Upgrade to RN 0.66 #4235
Conversation
The changes in this patch are now included from the upstream update.
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
d100ec7
to
fb7e0ec
Compare
I will test out the full manual testsuite for WPAndroid:
🟢 Writing FlowGeneral
Rich Text Format
Splitting and merging
Undo / Redo - Test Cases
🟢 Unsupported Block Editor
🟢 Sanity Tests (Test Suite 1)Gallery - 1
Gallery - 2
Gallery - 3
Columns - 1
Columns - 2
Columns - 3
MediaText - 1
MediaText - 2
MultipleUpload - 1
Cover - 1
Editor Theme - 1
Social Icons - 1
🟢 Sanity Tests (Test Suite 2)DarkMode - 1
Group - 1
Spacer - 1
Buttons-1
Buttons-2
Buttons-3Button-6
Color Settings - 1
Image - 1
🟢 Sanity Tests (Test Suite 3)Gallery - 2
Gallery - 3
Gallery - 4
Columns - 2
Columns - 3
Columns - 4
MediaText - 3
MediaText - 4Shortcode-1
Cover - 2
Social Icons - 2
Image - 2
Story block - 1 |
Result of `npm install` after updating the Gutenberg ref.
…e into chore/upgrade-to-react-native-0.66
…e into chore/upgrade-to-react-native-0.66
Second run captures commit sha of first run.
…e into chore/upgrade-to-react-native-0.66
Running the full manual testsuite for WPiOS:
🟢 Writing FlowGeneral
Rich Text Format
Splitting and merging
Undo / Redo - Test Cases
⚪ Unsupported Block Editor
🟢 Sanity Tests (Test Suite 1)Gallery - 1
Gallery - 2
Gallery - 3
Columns - 1
Columns - 2
Columns - 3
MediaText - 1
MediaText - 2
MultipleUpload - 1
Cover - 1
Editor Theme - 1
Social Icons - 1 |
🟡 Writing FlowGeneral
Rich Text Format
Splitting and merging
Undo / Redo - Test Cases🟢 Unsupported Block Editor
🟡 Sanity Tests (Test Suite 4)DarkMode - 2
Group - 2
Spacer - 2
Buttons - 4
Buttons - 5
Buttons - 7
Editor Theme - 2Color Settings - 2 |
…e into chore/upgrade-to-react-native-0.66
🟢 Sanity Tests (Test Suite 2) @twstokes
DarkMode - 1
Group - 1
Spacer - 1
Buttons-1
Buttons-2
Buttons-3Button-6
Color Settings - 1
Image - 1
🟡 Sanity Tests (Test Suite 3)
Gallery - 2
Gallery - 3
Gallery - 4
Columns - 2
Columns - 3
Columns - 4
MediaText - 3
MediaText - 4Shortcode-1
Cover - 2
Social Icons - 2
Image - 2
Story block - 1
🟡 Sanity Tests (Test Suite 4)
DarkMode - 2
Group - 2
Spacer - 2
Buttons - 4
Buttons - 5
Buttons - 7
Editor Theme - 2Color Settings - 2🟡 Sanity Tests (Test Suite 5)
Video block - 1
Video block - 2
File block - 1
File block - 2
File block - 3
Audio block - 1
Audio block - 2
Audio block - 3
Audio block - 4
Reusable block - 1 Reusable block - 2 Embed block - 1
Embed block - 2
|
Result of `npm install` after updating the Gutenberg version.
…e into chore/upgrade-to-react-native-0.66
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Once @twstokes has had a chance to look over the iOS side of things, let's get this shipped! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from the iOS side @dcalhoun. 👍
Related PRs
Description
Upgrade React Native to 0.66. See the React Native Upgrade Helper for additional details.
To test: See WordPress/gutenberg#36328.
PR submission checklist: