Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Contrast Checker to Text-Based Blocks #4357

Merged
merged 10 commits into from
Jan 12, 2022
Merged

Conversation

SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Dec 9, 2021

Fixes WordPress/gutenberg#33396

Gutenberg: WordPress/gutenberg#34902

With this PR, a contrast checker is added to the text-based blocks in the native apps.

Please refer to the Gutenberg PR as the "central PR" with the most up-to-date testing instructions.


PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@SiobhyB SiobhyB added [Type] Enhancement Improves a current area of the editor Accessibility labels Dec 9, 2021
@SiobhyB SiobhyB self-assigned this Dec 9, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 9, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

Copy link
Member

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SiobhyB SiobhyB merged commit 7436215 into develop Jan 12, 2022
@SiobhyB SiobhyB deleted the add/color-contrast-checker branch January 12, 2022 13:59
@SiobhyB SiobhyB added this to the 1.70.0 (19.1) milestone Jan 14, 2022
@fluiddot fluiddot mentioned this pull request Jan 20, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility [Type] Enhancement Improves a current area of the editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile: Low Contrast Checker/Notice for Text-Based Blocks
2 participants