Remove unused JSON asset files #4401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
2 tasks
The static JSON file assets are not the sourced by the app. Instead, the data found within the JavaScript bundle itself is utilized. The unnecessary static JSON files should now no longer be exported when bundling the JavaScript thanks to a bug fix in React Native. - #4329 (comment) - facebook/metro#593
dcalhoun
force-pushed
the
chore/remove-unused-json-assets
branch
from
a281611
to
f088e34
Compare
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
fluiddot
approved these changes
Jan 25, 2022
There was a problem hiding this comment.
LGTM 🎊 ! Thanks @dcalhoun for addressing this 🙇 .
I verified that running npm run bundle doesn't generate JSON assets, as well as testing that translations are present. Additionally, I double-checked that content of JSON files could be found in the latest bundle (bundle/App.js).
Tested on Simulator - iPhone 12 Pro Max (iOS 15.0).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The static JSON file assets are not the sourced by the app. Instead, the data found within the JavaScript bundle itself is utilized. The unnecessary static JSON files should now no longer be exported when bundling the JavaScript thanks to a bug fix in React Native.
To test:
Verify the bundle command does not generate JSON assets
npm run bundlebundledirectory.Verify the correct translation strings display
PR submission checklist: