Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LinkPicker freeze when virtual keyboard is hidden #4443

Merged

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Jan 7, 2022

This brings in WordPress/gutenberg#37782 to fix an app freeze after closing the link picker while a device's virtual keyboard is hidden.

To test: See WordPress/gutenberg#37782.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@dcalhoun dcalhoun self-assigned this Jan 7, 2022
@dcalhoun dcalhoun added the [Type] Bug Something isn't working label Jan 7, 2022
@dcalhoun dcalhoun requested a review from fluiddot January 7, 2022 16:34
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#37782 (review).

NOTE: We might consider adding an entry to the release notes with the changes.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jan 7, 2022

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@dcalhoun dcalhoun enabled auto-merge January 7, 2022 19:33
@dcalhoun dcalhoun merged commit 22d7e15 into develop Jan 7, 2022
@dcalhoun dcalhoun deleted the bug/fix-link-picker-freeze-when-virtual-keyboard-is-hidden branch January 7, 2022 19:56
@fluiddot fluiddot added this to the 1.69.1 (19.0) milestone Jan 10, 2022
@fluiddot
Copy link
Contributor

Heads up that I assigned this PR to the 1.69.1 (19.0) .

@mkevins mkevins mentioned this pull request Jan 18, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants