-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge release 1.69.1 to develop #4489
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
6c8ba3f
Release script: Update gb mobile version to 1.69.1
mkevins 0363bfa
Release script: Update gutenberg ref
mkevins 59ed92c
Release script: Update bundle for: 1.69.1
mkevins ba89e2b
Update release notes
mkevins 65ad7bf
Update bundle
mkevins 0718649
Merge branch 'trunk' into release/1.69.1
mkevins 703b310
Merge pull request #4477 from wordpress-mobile/release/1.69.1
mkevins 797d652
Merge branch 'develop' into merge_release_1.69.1_to_develop
mkevins b5a044d
Update gutenberg reference
mkevins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Submodule gutenberg
updated
7 files
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this was moved to
Unreleased
as it sounds like it was merged todevelop
after we cut the beta fix. I haven't confirmed timing of anything, but I saw that there was a pending question here. Was this confirmed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this looks like it was auto-resolved incorrectly by git (the PR had been created prior to the release branch, but it didn't land until after the cut, so it was actually in the "Unreleased" section of the notes in the PR itself. It seems that when it was merged into
develop
, the new version headings were already present in the notes, but this line was added under them, when it should have been "bumped" back up to the "new" "unreleased" section.The pending question there would be a good confirmation, but is mostly relevant for the current release wranglers of the
1.70.0
release, so they have clarity on where that note belongs.