Prevent validation error when viewing VideoPress markup within app #4899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'blocks/videopress/editor' file will import a hook that enables VideoPress previews within the app.
SiobhyB
changed the title
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
added 2 commits
May 31, 2022 16:53
added 2 commits
May 31, 2022 21:25
…ress-mobile/gutenberg-mobile into jetpack/enable-videopress-previews
jhnstn
approved these changes
Jun 3, 2022
|
@SiobhyB @jhnstn I see that the Jetpack PR was already merged, so I'm wondering if this PR could be merged, is there anything that blocks it? |
|
@fluiddot, thanks for the nudge! The only thing that was delaying me from going straight to merge was I wasn't certain of the status around the Jetpack submodule, given we were using an older reference for a long time. I've gone ahead to catch up on the conversations around that and see we're using a newer reference now, so there are no blockers to updating. I'll go ahead to update this PR and merge it. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes WordPress/gutenberg#30987
At the moment, blocks with VideoPress markup create a validation error within the app. This creates a problem as posts that contain videos (for sites with VideoPress enabled) are automatically converted to use VideoPress markup when saved on the web.
Related PRs
jetpack: [RNMobile] Prevent validation error when viewing VideoPress markup within app Automattic/jetpack#24548Description and Testing
Please refer to the Jetpack PR as the "central PR" with the most up-to-date details and testing instructions.
PR submission checklist: