Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alt image setting #531

Merged
merged 10 commits into from
Feb 4, 2019
Merged

Alt image setting #531

merged 10 commits into from
Feb 4, 2019

Conversation

etoledom
Copy link
Contributor

@etoledom etoledom commented Feb 1, 2019

This PR updates the Gutenberg reference to test the Alt image setting.
The main PR is found here: WordPress/gutenberg#13631

To test, refer to the gutenberg side PR.

(Updated GIF)
alt-setting

cc @iamthomasbishop

@etoledom etoledom changed the base branch from develop to issue/bottom-sheet-component February 1, 2019 08:00
@etoledom etoledom self-assigned this Feb 1, 2019
@etoledom etoledom added the [Type] Enhancement Improves a current area of the editor label Feb 1, 2019
@etoledom etoledom added this to the Beta milestone Feb 1, 2019
@etoledom etoledom changed the base branch from issue/bottom-sheet-component to develop February 1, 2019 10:28
@koke
Copy link
Member

koke commented Feb 4, 2019

The right-aligned text field looked good when static, but feels weird while typing. @iamthomasbishop what do you think?

Copy link
Contributor

@marecar3 marecar3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @etoledom

@iamthomasbishop
Copy link
Contributor

@koke I agree it's not perfect, but there are a number of considerations here and for the beta the alternatives aren't better, imo. I'd like to play with this in a test build before deciding to pivot. Some alternatives that come to mind:

  • Left-align values: this causes other visual alignment issues
  • Use two-line table-row style: sheet becomes much taller, not ideal

Long-term solution in my mind would be to iterate on this to utilize native table navigation/input patterns, for example:

  • Android: when table row is tapped, show dialog for text entry
  • iOS: show disclosure (> icon on right side of row, allow user to go down in hierarchy to a sub-page for text entry

Another option would be to stack a fresh sheet on top for entry, but that sounds like it could get visually disjointed if we start pulling sheets on top of sheets on top of sheets :)

@etoledom etoledom merged commit beca72c into develop Feb 4, 2019
@etoledom etoledom deleted the issue/alt-image-setting branch February 4, 2019 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement Improves a current area of the editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants