-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alt image setting #531
Alt image setting #531
Conversation
The right-aligned text field looked good when static, but feels weird while typing. @iamthomasbishop what do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @etoledom
f0500ea
to
9c120fa
Compare
@koke I agree it's not perfect, but there are a number of considerations here and for the beta the alternatives aren't better, imo. I'd like to play with this in a test build before deciding to pivot. Some alternatives that come to mind:
Long-term solution in my mind would be to iterate on this to utilize native table navigation/input patterns, for example:
Another option would be to stack a fresh sheet on top for entry, but that sounds like it could get visually disjointed if we start pulling sheets on top of sheets on top of sheets :) |
This PR updates the Gutenberg reference to test the Alt image setting.
The main PR is found here: WordPress/gutenberg#13631
To test, refer to the
gutenberg
side PR.(Updated GIF)
cc @iamthomasbishop