Upgrade React Native 0.71.11 - Android changes
#5872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 16, 2023
fluiddot
force-pushed
the
upgrade/react-native-0.71.8-android
branch
from
09f2e5a
to
f726421
Compare
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
The result of running: ``` rm -rf ./node_modules && npm install ```
…0.71.8-android # Conflicts: # package-lock.json
…0.71.8-android # Conflicts: # gutenberg
fluiddot
commented
Jun 30, 2023
| @@ -12,6 +12,9 @@ const { | |||
| } = e2eUtils; | |||
| import { NESTED_COLUMNS_3_LEVELS } from './test-editor-data'; | |||
|
|
|||
| const ANDROID_COLUMN_APPENDER_BUTTON_XPATH = | |||
There was a problem hiding this comment.
I haven't checked it further, but seems the native composition for Button has changed in the new version of RN or dependencies. I experienced something similar in Gutenberg with other elements (example).
fluiddot
commented
Jun 30, 2023
| const cellId = isAndroid() | ||
| ? 'Column 1. Width is 50 Percent (%)., double-tap to change unit' | ||
| : 'Column 1. Width is 50 Percent (%).'; | ||
| const cellId = 'Column 1. Width is 50 Percent (%).'; |
There was a problem hiding this comment.
Similar to this change, the accessibility hint is no longer appended to the accessibility content description on Android.
dcalhoun
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
0.71.11- Android changes WordPress/gutenberg#512890.71.11WordPress-Android#18613To test:
0.71.11- iOS changes #5881.0.71.11WordPress/gutenberg#51303.PR submission checklist: