Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.100.1 #5985

Merged
merged 8 commits into from
Jul 21, 2023
Merged

Release 1.100.1 #5985

merged 8 commits into from
Jul 21, 2023

Conversation

derekblank
Copy link
Contributor

@derekblank derekblank commented Jul 21, 2023 •
edited
Loading

Release for Gutenberg Mobile 1.100.1

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes in 1.100.0

Note that changes from 1.100.0 are included in this PR, as release PR #5981 will be closed in favor of this one.

Change 1: Move undo/redo buttons to header toolbar

Change 2: Update blue borders around blocks

Change 3: Style and Color Updates

Change 4: Update toolbar icons and colors

Change 5: Expand analytics for block insertion/replacement

Change 6: Add media inserter blocks to toolbar

Changes in 1.100.1

Change 1: E2E tests - Update hiding of the keyboard for iPad

Change 2: Fix crash when registering non-core blocks

Test plan

Once the installable builds of the main apps are ready, perform a quick smoke test of the editor on both iOS and Android to verify it launches without crashing. We will perform additional testing after the main apps cut their releases.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
  • Bundle package of the release is updated.

This was referenced Jul 21, 2023
Merged
Merged
Merged
@derekblank derekblank marked this pull request as ready for review July 21, 2023 03:00
@fluiddot fluiddot mentioned this pull request Jul 21, 2023
Closed
4 tasks
fluiddot
fluiddot approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊 !

I confirmed this PR was branched off from a trunk's commit that includes the fixes:

@fluiddot fluiddot merged commit 231596e into trunk Jul 21, 2023
@fluiddot fluiddot deleted the release/1.100.1 branch July 21, 2023 14:50
@derekblank
Copy link
Contributor Author

derekblank commented Jul 25, 2023 •
edited
Loading

🟢 Writing Flow (iOS)

Build: 22.9.0.0 (TestFlight)
Device: iPhone SE (iOS 16.5.1)

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC007 - Test format detection under the cursor
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading

@derekblank
Copy link
Contributor Author

derekblank commented Jul 25, 2023 •
edited
Loading

🟢 Unsupported Block Tests (iOS)

Build: 22.9.0.0 (TestFlight)
Device: iPhone SE (iOS 16.5.1)

  • TC001 - User can edit unsupported blocks on Simple WP.com sites
  • TC002 - User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 - Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 - Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 - Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 - Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@derekblank
Copy link
Contributor Author

derekblank commented Jul 25, 2023 •
edited
Loading

🟢 Release Changes (iOS)

Build: 22.9.0.0 (TestFlight)
Device: iPhone SE (iOS 16.5.1)

@derekblank
Copy link
Contributor Author

derekblank commented Jul 25, 2023 •
edited
Loading

🟢 Functionality Test Suite 1 (iOS)

Build: 22.9.0.0 (TestFlight)
Device: iPhone SE (iOS 16.5.1)

Gallery - 1

  • Gallery block - Close/Re-open post with an ongoing image upload - TC001
  • Gallery block - Close post with an ongoing image upload - TC002

Gallery - 2

  • Gallery block - Insert image from device (failing) - TC006
  • Gallery block - Insert image from device (cancel) - TC009
  • Gallery block - Try adding same images from WP Media library and moving the images around - TC010

MediaText - 1

  • Media Text block - Insert image from device (failing) - TC001
  • Media Text block - Close/Re-open post with an ongoing image upload - TC003

MediaText - 2

  • Media Text block - Insert video from device - TC002-v
  • Media Text block - Insert image from device - TC002-i

MultipleUpload - 1

  • Simultaneous uploads - TC001

Cover - 1

  • Cover - Add image background from WordPress Media library - TC001
  • Cover - Image focal point is rendered properly - TC002
  • Cover - Custom color is rendered properly - TC002

Editor Theme - 1

  • Default Colors - Check that default colors still load - TC001
  • Default Gradients - Check that default gradients still load - TC002
  • Custom Colors - Check that custom colors load in the editor - TC003

Social Icons - 1

  • Active icon gets product color - TC001
  • Social icon forwarding to the link - TC002

@derekblank
Copy link
Contributor Author

derekblank commented Jul 25, 2023 •
edited
Loading

🟢 Writing Flow (Android)

Build: jpandroid-22.9-rc-1
Device: Samsung Galaxy S20 FE (Android 12)

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC007 - Test format detection under the cursor
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading

Undo / Redo - Test Cases

@derekblank
Copy link
Contributor Author

derekblank commented Jul 26, 2023 •
edited
Loading

🟢 Unsupported Block Tests (Android)

Build: jpandroid-22.9-rc-1
Device: Samsung Galaxy S20 FE (Android 12)

  • TC001 - User can edit unsupported blocks on Simple WP.com sites
  • TC002 - User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 - Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 - Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 - Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 - Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@derekblank
Copy link
Contributor Author

derekblank commented Jul 26, 2023 •
edited
Loading

🟢 Functionality Test Suite 5 (Android)

Build: jpandroid-22.9-rc-1
Device: Samsung Galaxy S20 FE (Android 12)

Video block - 1

  • Video block - Insert video from device (failing) - TC001
  • Video block - Close/Re-open post with an ongoing video upload - TC004

Video block - 2

  • Video block - Insert video from device (cancel) - TC002
  • Video block - Close post with an ongoing video upload - TC005
  • Video block - Add Caption - TC003

File block - 1

  • File block - Upload completes successfully from the device library - TC001
  • File block - Insert completes successfully from the WordPress Media library - TC002
  • File block - Upload fails from the device library - TC003
  • File block - Stop the file upload before it completes - TC004

File block - 2

  • File block - Close the post with an ongoing file upload - TC005
  • File block - Replace the selected files - TC006
  • File block - Change the alignment in the File Block - TC007
  • File block - The Link To Block Setting should open - TC008

File block - 3

  • File block - Open link in new tab - TC009
  • File block - Show/hide download button (Block Settings only) - TC010
  • File block - Copy file URL - TC011
  • File block - Close/Re-open post with an ongoing file upload - TC012

Audio block - 1

  • Audio block - Upload completes successfully from the device library - TC001
  • Audio block - Insert completes successfully from the WordPress Media library - TC002

Audio block - 2

  • Audio block - Upload fails from the device library - TC003
  • Audio block - Stop the audio file upload before it completes - TC004

Audio block - 3

  • Audio block - Close the post with an ongoing audio file upload - TC005
  • Audio block - Replace the selected files - TC006
  • Audio block - Change the alignment in the Audio Block - TC007

Audio block - 4

  • Audio block - Autoplay setting - TC008
  • Audio block - Loop setting - TC009
  • Audio block - Close/Re-open post with an ongoing audio file upload - TC010

Synced patterns - 1

  • Synced patterns - Add pattern - TC001
  • Synced patterns - Detach pattern - TC002

Synced patterns - 2

  • Synced patterns - Deleted pattern - TC003
  • Synced patterns - Recursive block rendering - TC004

Embed block - 1

  • Embed block - Inline previews are rendered correctly for the top 5 most-used providers - TC001

Embed block - 2

  • Embed block - Inline previews are rendered accordingly for each alignment option - TC002

@derekblank
Copy link
Contributor Author

derekblank commented Jul 26, 2023 •
edited
Loading

🟢 Release Changes (Android)

Build: jpandroid-22.9-rc-1
Device: Samsung Galaxy S20 FE (Android 12)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluiddot fluiddot fluiddot approved these changes

@geriux geriux Awaiting requested review from geriux

Assignees
No one assigned
Labels
release-process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derekblank @fluiddot