Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Functionality Test: Themes for Appium 2 #6292

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Update Functionality Test: Themes for Appium 2 #6292

merged 1 commit into from
Oct 18, 2023

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Oct 17, 2023

Related PRs

What?

This PR updates the Functionality Test Themes suite to WebdriverIO and Appium 2.

Why?

To continue with the migration effort to support this new version and new driver.

How?

  • Replace the usage of sleep in favor of pause

Testing Instructions

Local tests should pass by running the following command for both platforms:

Android

TEST_RN_PLATFORM=android npm run device-tests:local gutenberg-editor-functionality-test-themes-visual.test

iOS

TEST_RN_PLATFORM=ios npm run device-tests:local gutenberg-editor-functionality-test-themes-visual.test

I've also confirmed it runs on SauceLabs by triggering the test from a local command against the Appium 2 build.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@geriux geriux added the Testing Anything related to automated tests label Oct 17, 2023
@geriux geriux mentioned this pull request Oct 17, 2023
Merged
7 tasks
@geriux geriux requested a review from dcalhoun October 17, 2023 16:58
dcalhoun
dcalhoun approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test plan succeeded. 🚀

@geriux geriux merged commit 841dd3d into version-toolkit/gutenberg/rnmobile/appium-2 Oct 18, 2023
1 check passed
@geriux geriux deleted the test/functionality-test-themes-migration branch October 18, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcalhoun dcalhoun dcalhoun approved these changes

Assignees
No one assigned
Labels
Testing Anything related to automated tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geriux @dcalhoun