Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load the data package from local GB source tree #68

Merged
merged 1 commit into from
Jul 17, 2018
Merged

Load the data package from local GB source tree #68

merged 1 commit into from
Jul 17, 2018

Conversation

hypest
Copy link
Contributor

@hypest hypest commented Jul 10, 2018

Fixes #67

With #66, the @wordpress/data package is pulled from NPM while the @wordpress/element from local GB source. Thing is, data tries to pull in the element package as well and that gets resolved from NPM. Apparently this ends up messing up with the locally loaded element package too. So, even though the data package doesn't contain any mobile native code (and thus we could just pull it from NPM) we seem forced to load it from local too.

This PR let's @wordpress/data be resolved from the local GB source tree.

To test

  1. Delete the local node_modules folder
  2. Install the packages: yarn install
  3. Clean-Start the bundler: yarn start:reset
  4. In a separate terminal window build/install the app: yarn android or yarn ios
  5. Notice the app launching normally

@hypest
Load the data package from local GB source tree
d6fc36e 
Otherwise, `data` tries to pull in the `element` package from NPM and
apparently this ends up messing with the locally loaded `element`
package too. So, even though the `data` package doesn't contain mobile
native code (and thus we could just pull it from NPM) we seem forced to
load it from local too.
@hypest hypest requested a review from mzorz July 10, 2018 22:19
@SergioEstevao SergioEstevao self-requested a review July 17, 2018 16:09
SergioEstevao
SergioEstevao approved these changes Jul 17, 2018
View reviewed changes
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR makes the project to bundle and build correctly again! :shipit:

@hypest hypest merged commit ebea146 into master Jul 17, 2018
@hypest hypest deleted the fix/load-data-package-from-source branch July 17, 2018 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

@mzorz mzorz Awaiting requested review from mzorz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hypest @SergioEstevao