Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.119.1 #6907

Merged
merged 9 commits into from
Jun 5, 2024
Merged

Release 1.119.1 #6907

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6b13441
Release script: Update gutenberg submodule
geriux Jun 4, 2024
00db018
1.119.1
geriux Jun 4, 2024
14d46b2
Release script: Update i18n files for 1.119.1
geriux Jun 4, 2024
a8a0235
Release script: Sync XCFramework `Podfile.lock` with 1.119.1
geriux Jun 4, 2024
788c118
Release script: Update release notes for version 1.119.1
geriux Jun 4, 2024
85bc1c0
Update Unsupported block tests
geriux Jun 4, 2024
ca42a8b
Update Gutenberg ref
geriux Jun 4, 2024
fb5a7eb
Merge branch 'trunk' into release/1.119.1
geriux Jun 5, 2024
526b0af
Disable social icons test
geriux Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions RELEASE-NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
Unreleased
---

1.119.1
---
* [*] Image corrector - Check the path extension is a valid one [https://github.com/WordPress/gutenberg/pull/62190]
* [*] Unsupported block - UI improvements [https://github.com/WordPress/gutenberg/pull/62240]

1.119.0
---
* [*] Cancel failed or in progress uploads if the media block is removed [https://github.com/wordpress-mobile/gutenberg-mobile/pull/6841]
Expand Down
39 changes: 9 additions & 30 deletions __device-tests__/gutenberg-editor-unsupported-block-visual.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* Internal dependencies
*/
const { isAndroid, toggleDarkMode } = e2eUtils;
import { takeScreenshot } from './utils';
import { takeScreenshot, takeScreenshotByElement } from './utils';

describe( 'Gutenberg Editor Visual test for Unsupported Block', () => {
it( 'should show the empty placeholder for the selected/unselected state', async () => {
Expand All @@ -13,22 +13,11 @@ describe( 'Gutenberg Editor Visual test for Unsupported Block', () => {
const unsupportedBlock = await editorPage.getBlockAtPosition(
editorPage.blockNames.unsupported
);
await unsupportedBlock.click();
// Wait for the block to be selected
await editorPage.driver.pause( 500 );

// Visual test check
let screenshot = await takeScreenshot();
expect( screenshot ).toMatchImageSnapshot();

// Select title to unfocus the block
const titleElement = await editorPage.getTitleElement();
await titleElement.click();

await editorPage.dismissKeyboard();

// Visual test check
screenshot = await takeScreenshot();
const screenshot = await takeScreenshotByElement( unsupportedBlock, {
padding: 7,
} );
expect( screenshot ).toMatchImageSnapshot();
} );

Expand All @@ -42,28 +31,18 @@ describe( 'Gutenberg Editor Visual test for Unsupported Block', () => {
const unsupportedBlock = await editorPage.getBlockAtPosition(
editorPage.blockNames.unsupported
);
await unsupportedBlock.click();
// Wait for the block to be selected
await editorPage.driver.pause( 1000 );

// Visual test check
let screenshot = await takeScreenshot();
expect( screenshot ).toMatchImageSnapshot();

// Select title to unfocus the block
const titleElement = await editorPage.getTitleElement();
await titleElement.click();

await editorPage.dismissKeyboard();

// Visual test check
screenshot = await takeScreenshot();
const screenshot = await takeScreenshotByElement( unsupportedBlock, {
padding: 7,
} );
expect( screenshot ).toMatchImageSnapshot();

await toggleDarkMode( editorPage.driver, false );
} );

it( 'should be able to open the unsupported block web view editor', async () => {
// Disabled temporarily
it.skip( 'should be able to open the unsupported block web view editor', async () => {
geriux marked this conversation as resolved.
Show resolved Hide resolved
await editorPage.initializeEditor( {
initialData: e2eTestData.unsupportedBlockHtml,
} );
Expand Down
Binary file removed ...lock-should-be-able-to-open-the-unsupported-block-web-view-editor-1-android.png
View file
Open in desktop
fluiddot marked this conversation as resolved.
Show resolved Hide resolved
Binary file not shown.
Binary file removed ...ed-block-should-be-able-to-open-the-unsupported-block-web-view-editor-1-ios.png
View file
Open in desktop
Binary file not shown.
Binary file modified ...ould-show-the-empty-placeholder-for-the-selected-unselected-state-1-android.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...k-should-show-the-empty-placeholder-for-the-selected-unselected-state-1-ios.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed ...ould-show-the-empty-placeholder-for-the-selected-unselected-state-2-android.png
View file
Open in desktop
Binary file not shown.
Binary file removed ...k-should-show-the-empty-placeholder-for-the-selected-unselected-state-2-ios.png
View file
Open in desktop
Binary file not shown.
Binary file modified ...-empty-placeholder-for-the-selected-unselected-state-in-dark-mode-1-android.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...-the-empty-placeholder-for-the-selected-unselected-state-in-dark-mode-1-ios.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed ...-empty-placeholder-for-the-selected-unselected-state-in-dark-mode-2-android.png
View file
Open in desktop
Binary file not shown.
Binary file removed ...-the-empty-placeholder-for-the-selected-unselected-state-in-dark-mode-2-ios.png
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions bundle/android/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,7 @@ translators: %s: Select control option value e.g: "Auto, 25%". -->
<string name="gutenberg_native_tap_here_to_copy_post_text" tools:ignore="UnusedResources">Tap here to copy post text</string>
<string name="gutenberg_native_tap_here_to_show_help" tools:ignore="UnusedResources">Tap here to show help</string>
<string name="gutenberg_native_tap_here_to_show_more_details" tools:ignore="UnusedResources">Tap here to show more details.</string>
<string name="gutenberg_native_tap_to_edit" tools:ignore="UnusedResources">Tap to edit</string>
geriux marked this conversation as resolved.
Show resolved Hide resolved
<string name="gutenberg_native_tap_to_hide_the_keyboard" tools:ignore="UnusedResources">Tap to hide the keyboard</string>
<string name="gutenberg_native_text_color" tools:ignore="UnusedResources">Text color</string>
<string name="gutenberg_native_text_formatting_controls_are_located_within_the_toolbar_positione" tools:ignore="UnusedResources">Text formatting controls are located within the toolbar positioned above the keyboard while editing a text block</string>
Expand Down
1 change: 1 addition & 0 deletions bundle/ios/GutenbergNativeTranslations.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,7 @@ private func dummy() {
_ = NSLocalizedString("Tap here to copy post text", comment: "")
_ = NSLocalizedString("Tap here to show help", comment: "")
_ = NSLocalizedString("Tap here to show more details.", comment: "")
_ = NSLocalizedString("Tap to edit", comment: "")
_ = NSLocalizedString("Tap to hide the keyboard", comment: "")
_ = NSLocalizedString("Text color", comment: "")
_ = NSLocalizedString("Text formatting controls are located within the toolbar positioned above the keyboard while editing a text block", comment: "")
Expand Down
2 changes: 1 addition & 1 deletion gutenberg
Open in desktop
Submodule gutenberg updated 13 files
+3 −3 package-lock.json
+39 −11 packages/block-library/src/missing/edit.native.js
+76 −60 packages/block-library/src/missing/test/__snapshots__/edit.native.js.snap
+4 −1 packages/blocks/src/api/raw-handling/image-corrector.native.js
+12 −0 packages/edit-post/src/test/__snapshots__/editor.native.js.snap
+34 −0 packages/edit-post/src/test/editor.native.js
+1 −1 packages/react-native-aztec/package.json
+26 −1 packages/react-native-bridge/common/gutenberg-web-single-block/editor-style-overrides.css
+1 −1 packages/react-native-bridge/package.json
+4 −0 packages/react-native-editor/CHANGELOG.md
+4 −4 packages/react-native-editor/ios/Podfile.lock
+1 −1 packages/react-native-editor/package.json
+7 −6 test/native/integration-test-helpers/rich-text-paste.js
4 changes: 2 additions & 2 deletions ios-xcframework/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1104,7 +1104,7 @@ PODS:
- React-RCTImage
- RNSVG (14.0.0):
- React-Core
- RNTAztecView (1.119.0):
- RNTAztecView (1.119.1):
- React-Core
- WordPress-Aztec-iOS (= 1.19.11)
- SDWebImage (5.11.1):
Expand Down Expand Up @@ -1399,7 +1399,7 @@ SPEC CHECKSUMS:
RNReanimated: f705119af7f77c961122a09adbfdf3dd38ce6a60
RNScreens: d07e03170921286b65f07e7b2a3aa8300f61f2ec
RNSVG: eb0b170443191e4a1af53b9bd17d1f2fbd1ba152
RNTAztecView: c0a124a24b01a96ceeac8c0dcdc461f2d06e13f2
RNTAztecView: 268a6489f223c3a91afa2ba5ee7bef82df900c69
SDWebImage: a7f831e1a65eb5e285e3fb046a23fcfbf08e696d
SDWebImageWebPCoder: 908b83b6adda48effe7667cd2b7f78c897e5111d
SocketRocket: f32cd54efbe0f095c4d7594881e52619cfe80b17
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "gutenberg-mobile",
"version": "1.119.0",
"version": "1.119.1",
"private": true,
"config": {
"jsfiles": "./*.js src/*.js src/**/*.js src/**/**/*.js",
Expand Down