Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix - HTML Editor - Keyboard can not be closed #743

Merged
merged 2 commits into from
Mar 13, 2019
Merged

Fix - HTML Editor - Keyboard can not be closed #743

merged 2 commits into from
Mar 13, 2019

Conversation

pinarol
Copy link
Contributor

@pinarol pinarol commented Mar 13, 2019

Fix #428

On iOS there was no way of closing the keyboard on HTML mode, now we are adding keyboardDismissMode option, so user can drag down to close the keyboard.

Android behavior doesn't change. On Android there's already a keyboard down button. The 'interactive' option is supported for iOS only, so Android will continue having the default value: https://facebook.github.io/react-native/docs/scrollview#keyboarddismissmode

keyboard-drag

To Test

  • Run metro on this branch
  • Go to WPiOS app
  • Open a post and switch to HTML mode
  • Tap somewhere to open keyboard
  • Verify that drag down closes the keyboard

@pinarol pinarol added this to the v1.2 milestone Mar 13, 2019
@pinarol pinarol self-assigned this Mar 13, 2019
@pinarol pinarol requested a review from SergioEstevao March 13, 2019 12:52
@daniloercoli
Copy link
Contributor

Not sure if's a local problem or not, but when I switch to the HTML mode on the emulator I get part of the screen blank. See the picture below:
Screen Shot 2019-03-13 at 15 13 08

@etoledom
Copy link
Contributor

@daniloercoli I have seen that too on the example app, but I haven't been able to reproduce it on the WPiOS app.

I couldn't test Android since there is no option to switch to HTML in the Android example app 🤔

@daniloercoli
Copy link
Contributor

I couldn't test Android since there is no option to switch to HTML in the Android example app 🤔

Will try in it the wp-android app.

@etoledom
Copy link
Contributor

etoledom commented Mar 13, 2019 •
edited
Loading

@daniloercoli - I also noticed that the HTML textview does not display all the HTML text.
It's not related to this PR but maybe it is related to the addition of the wrapper ScrollView?

@daniloercoli
Copy link
Contributor

Tested by integrating this PR in wp-androind and the HTML view works as expected.

@daniloercoli daniloercoli self-requested a review March 13, 2019 15:13
daniloercoli
daniloercoli approved these changes Mar 13, 2019
View reviewed changes
Copy link
Contributor

@daniloercoli daniloercoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected on Android. Also tested iOS and it worked fine.

@pinarol
Copy link
Contributor Author

pinarol commented Mar 13, 2019

Thanks @daniloercoli 🎉
I have opened an issue for that #744
It looks like it is broken on develop branch also.

@pinarol pinarol merged commit eb5612e into develop Mar 13, 2019
@pinarol pinarol deleted the issue/428-html-mode-keyboard-dismiss branch March 13, 2019 15:23
daniloercoli added a commit that referenced this pull request Mar 14, 2019
@daniloercoli
Merge branch 'develop' of https://github.com/wordpress-mobile/gutenbe…
2eb9671 
…rg-mobile into issue/707-Placeholder-is-missing-on-Heading-block

* 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile: (22 commits)
  Update gutenberg ref
  Update gutenberg ref
  Update gutenberg ref
  Update heading placeholder size on heading level change (#742)
  Fix - HTML Editor - Keyboard can not be closed (#743)
  Update gutenberg ref
  Update gutenberg ref
  Fix lint errors
  Make sure onSafeAreaInsetsUpdate isn't called when BlockManager is unmounted
  Remove extra semicolon
  Remove unused editor settings prop
  Unmount the app after each test to prevent dangling subscribers
  Fix switching to html when initialHtmlModeEnabled is true
  Auto import native versions of variables and colors
  Fix lint errors
  Use @wordpress/edit-post package to bootstrap the editor and refactor components
  Add symlink for @wordpress/token-list
  Minor syntax fixes
  Update tests to use the un deprecated version of the store methods
  Update gutenberg ref
  ...

# Conflicts:
#	gutenberg
daniloercoli added a commit that referenced this pull request Mar 15, 2019
@daniloercoli
Merge branch 'develop' of https://github.com/wordpress-mobile/gutenbe…
4ab812f 
…rg-mobile into issue/345-fix-for-press-delete-no-merge-move-focus

* 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile: (39 commits)
  Update gb hash after merging the companion PR
  Update GB ref
  Update gutenberg ref
  Update gutenberg ref
  Update gutenberg ref
  Tests: Add mock for the newly added CSS class
  Update GB ref
  Raise the minHeight value for heading block to 60 (it was 50)
  Introduce a constant for the string `tag` and use it instead of the hard coded string
  Make `tagName` private
  Update heading placeholder size on heading level change (#742)
  Fix - HTML Editor - Keyboard can not be closed (#743)
  Update gutenberg ref
  Update gutenberg ref
  Update GB ref
  Add comments
  Update caret position after inserting link (#716)
  Update GB hash
  Reuse `blockType` instead of adding a new property
  Update GB ref
  ...

# Conflicts:
#	src/block-management/block-holder.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniloercoli daniloercoli daniloercoli approved these changes

@SergioEstevao SergioEstevao Awaiting requested review from SergioEstevao

Assignees

@pinarol pinarol

Labels
[OS] iOS
Projects
None yet
Milestone
v1.1.1
Development

Successfully merging this pull request may close these issues.

HTML Editor - Keyboard can not be closed
3 participants
@pinarol @daniloercoli @etoledom