2nd Fix for Placeholder on Heading block

[daniloercoli]

This PR is a second tentative on fixing #707 and uses much of the code introduced in #739 but doesn't relies on eventCount , instead it actually checks the previous text if it's empty or not, before wrapping the newly inserted text with default tag.

cc @marecar3

To test this PR

Test 1

• Add a new heading block
• The placeholder text should appear
• Start typing in the block
• The styling should be there and the toolbar updated

Test 2

• Remove all the text in a Heading block
• The placeholder text should appear again
• Start typing in the block
• The styling should be there and the toolbar updated

Test 3

• Add a new heading block
• The placeholder text should appear
• Paste a text in the block
• The styling should be there and the toolbar updated

Make sure to test with Heading block added at the end of the main list.

[marecar3]

Hey, @daniloercoli I have found a bug on Paragraph block.

Steps :

• Create a new paragraph
• Write some text
• Select all as bold
• Move to the beginning of the text
• Start typing new text

Result -> Every other letter will be bold.

[daniloercoli]

Is it related to these changes @marecar3? Would you mind to test develop, since I guess it's the default behavior of Aztec.

I tried the steps above on a old version of the editor, and can reproduce it, the toolbar button B is not highlighted in your picture though, instead here is highlighted.

Steps I tried:

• Create a new paragraph
• Write some text
• Select all with the context menu
• Apply Bold
• Move to the beginning of the text
• Start typing new text

[marecar3]

Hey @daniloercoli, I couldn't reproduce it on develop branch.

[daniloercoli]

Maybe i didn't get the testing steps to reproduce the problem, but this is what I see on develop when applying bold on a para block, and then start typing at the beginning:

[daniloercoli]

It seems that there were already problems on develop in regards the formatting bar. After a chat convo I made 2 videos to show other variations of the initial problem reported by @marecar3.
Pasting here the link to 2 videos I made running develop on a testing device of mine. https://cloudup.com/ct7LMVYR4J0

I guess we can open a new issue, and move forward this PR. To test it again, just put a breakpoint inside the if condition here and see that it's not hit at all during the testing steps reported above.

[marecar3]

Hey @daniloercoli , thanks for the confirmation, LGTM! Let's move forward.

Please, if you can open the new issue for problem that we have found on the develop? Thanks.