-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nested lists #991
Nested lists #991
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @SergioEstevao - Tested on iOS and it's looking good 🎉
- First of all try, the issue stated on List block split problem with nested lists #874 to see if it's working correctly
The issue seems to be completely fixed ✅
- Then try to use the indent and outdent buttons and see if they work correctly
This one is working mostly fine. I did find a small issue (in both iOS and Android):
- Create a list with a couple of indented items at the end.
- Select another block.
- Select again the list with the cursor in the last item
- Press "de-indent" (<-) to try to remove the indentation of the last item.
- It won't work.
- Try to delete list items and see if it works correctly
This one also works good! ✅
There is an issue spotted by @Tug (WordPress/gutenberg#15566 (comment)) but it seems to be a web issue (or expected behavior?) WordPress/gutenberg#15566 (comment)
I found another issue that is reproducible in the web side:
- Copy this test html and paste it in gutenberg-mobile:
<!-- wp:list -->
<ul><li>line 1<ul><li>line 21</li><li>line 22<ul><li>line 31</li><li>line 32</li></ul></li></ul></li><li>line 3</li><li>line 4</li><li>line 5</li></ul>
<!-- /wp:list -->
- Set the caret at the end of the last item
- Press enter to break out of the list block
- In the new paragraph block, press backspace to merge.
- Check what happened to the indented list items from above (they all merged in one).
From all these issues, only the first one described seems to be related to only gutenberg-mobile
.
# Conflicts: # gutenberg # react-native-aztec/ios/Cartfile # react-native-aztec/ios/Cartfile.resolved
@etoledom and @daniloercoli merged latest develop on this PR. Do you mind to give it another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in chat convo this PR is in a good shape, and working mostly fine on Android also.
We noticed the problem with the backspace that doesn't "outdent" the item in nested listed, instead it merges the current item with the one above.
Not a big problem anyway, and we will tackle it in a following PR. cc @mkevins
Btw, while testing this "hardly" I got a crash with the caret set out of bounds. Was not able to reproduce the issue in following tests, so it may be a rare case, but worth to take an eye on it.
LGTM!
Tested this and it seems to be fixed ✅ |
A heads up: Edit: Not sure about tests on Device. |
Fixes: #874
Related GB PR: WordPress/gutenberg#15566
Relate Aztec PR: wordpress-mobile/AztecEditor-iOS#1181
This PR updates the list code to support the following:
How to test: