Changes to integrate with WPiOS app. #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… require modifying imports.
…-mobile/react-native-aztec into feature/adding-podspec
etoledom
commented
Nov 7, 2018
| #import <React/RCTViewManager.h> | ||
|
|
||
| // USE "WordPress-Swift.h" to run on WPiOS, or "RNTAztecView-Swift.h" to run Example App. |
There was a problem hiding this comment.
This is a small hack to be able to build WPiOS app. I plan to remove this in the near future.
diegoreymendez
approved these changes
Nov 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces some changes to integrate with the WPiOS app.
I opted for temporarily remove images and attachment handling in favour of a simpler Bridge implementation. This is to avoid a direct dependency between
AztecandRNReactNativeGutenbergBridge.We might find out that this dependency is unavoidable, but for simplicity sake on this first step, I'd prefer to work without it. I plan to reimplement or clean up the commented code as soon as we decide on the path to follow with the general integration.
This PR also adds a
podspecfile, but is not really being used yet. I plan to use it in the near future and I'd like to keep it here for now. We can remove it later if we end up not using it at all.We need to merge this before merging the main iOS bridge implementation.
To test:
Paragraphblock contains attachments.