Bump react-native to version 0.71.8
#23
Conversation
fluiddot
changed the title
react native to version 0.71.8react-native to version 0.71.8
build.gradle.kts
Outdated
| substitute(module("com.facebook.react:react-android")) | ||
| .with(module("com.facebook.react:react-android:$reactNativeVersion")) | ||
| substitute(module("com.facebook.react:hermes-android")) | ||
| .with(module("com.facebook.react:hermes-android:$reactNativeVersion")) | ||
| // For backward-compatibility, we also substitute `react-native` module | ||
| // with the new module `react-android`. | ||
| substitute(module("com.facebook.react:react-native")) | ||
| .with(module("com.facebook.react:react-android:$reactNativeVersion")) |
There was a problem hiding this comment.
This follows the process performed by the React Native Gradle plugin (reference, docs). Additionally, as shared in this proposal, now the React Native and Hermes modules are published to Maven, similar to what we do in “react-native-mirror-publisher” repository.
There was a problem hiding this comment.
@fluiddot If the changes in this PR work as expected, they look good to me. I did leave a suggestion about removing the reactNativeMinorVersion property and the if check it's used in as I don't think it's necessary.
I also left a suggestion about the react-native-mirror to react-android change.
Neither of these are blocking this PR, so feel free to merge it as is.
build.gradle.kts
Outdated
| // This substitution is based on React Native Gradle plugin. | ||
| // Reference: https://t.ly/38jk | ||
| substitute(module("com.facebook.react:react-android")) | ||
| .with(module("com.facebook.react:react-android:$reactNativeVersion")) |
There was a problem hiding this comment.
I think due to this react-native to react-android change, we need to stop using our own mirror from react-native-mirror-publisher. I think we can start using the artifacts published to mavenCentral and archive the react-native-mirror-publisher project.
If we keep using our own mirror, we might get duplicate class errors. Even if we don't, it wouldn't be great to have dependencies on both react-android & react-native-mirror.
The same goes for the hermes-android, of course.
@fluiddot What do you think?
P.S: If you all decide to go through with this ^ suggestion, please let me know if you need any help!
There was a problem hiding this comment.
I think due to this
react-nativetoreact-androidchange, we need to stop using our own mirror from react-native-mirror-publisher. I think we can start using the artifacts published tomavenCentraland archive thereact-native-mirror-publisherproject.
That's correct. From now on, we won't need the mirror repository to publish React Native and Hermes. Hence, we could archive react-native-mirror-publisher project. In any case, I'd wait until the RN upgrade is fully released to do so.
If we keep using our own mirror, we might get duplicate class errors. Even if we don't, it wouldn't be great to have dependencies on both
react-android&react-native-mirror.The same goes for the
hermes-android, of course.@fluiddot What do you think?
P.S: If you all decide to go through with this ^ suggestion, please let me know if you need any help!
I completely agree. In fact, as part of the RN upgrade effort, I'm removing all references to the mirror in Gutenberg and WP-Android, in favor of using the ones published in mavenCentral.
fluiddot
force-pushed
the
bump-react-native-0.71.8
branch
from
d412c4b
to
f76aaf6
Compare
There was a problem hiding this comment.
Thank you for putting this together. I really appreciate the comments explaining code logic, as I am unfamiliar with this repository or its scripts.
I wanted to share that I ran into the following error when following the testing instructions. I presume it is unrelated to these changes. WDYT?
FAILURE: Build failed with an exception.
* What went wrong:
A problem occurred configuring project ':react-native-clipboard'.
> SoftwareComponentInternal with name 'release' not found.
I realized this error occurred as I did not run I will open a separate PR updating the project README documenting setup steps. |
Oh, sorry for that, I forgot to add that step. I'll update the PR's description.
Yeah, good idea. I thought about that when working on this PR, as we don't have instructions for testing 👍 . |
@dcalhoun based on this comment, I assume you were able to test the PR, would you mind if I merge the PR without your explicit PR approval? Thanks! |
There was a problem hiding this comment.
@dcalhoun based on this comment, I assume you were able to test the PR, would you mind if I merge the PR without your explicit PR approval? Thanks!
Yes, I did test and you are welcome to merge. I only abstained from an approval due to the error and my own lack of expertise in this repository. In the future, feel free to always merge as you see fit if you have approval from someone else.
Bumps the React Native version to
0.71.8. This also implied updating the module substitution block to reflect the new process for fetching the React Native and Hermes modules.How to test
npm install../gradlew publishToMavenLocal -exclude-task prepareToPublishToS3.~/.m2/repository/org/wordpress-mobile/react-native-libraries.