Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff between wp-fork-2.17.0 branch and main repo's 2.17.0 version #26

Draft
wants to merge 3 commits into
base: trunk-2.17.0
Choose a base branch
from

Conversation

fluiddot
Copy link

@fluiddot fluiddot commented Jul 5, 2023

Tweaks incorporated in this branch

  • Workaround for an issue in podspec file and setting custom node_modules location via an environment variable.

Integration with Gutenberg Mobile

This branch is only used during pod installation, so it's only needed to reference this branch in the pod. E.g.:

pod 'RNReanimated', git: 'https://github.com/wordpress-mobile/react-native-reanimated', branch: 'wp-fork-2.17.0'

The previous version used the user-defined
`REACT_NATIVE_NODE_MODULES_DIR` as a fallback to read the React Native
`package.json` but forgot to use it later on when looking for
`ReactCommon`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants