Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.1.0 into develop #305

Merged
merged 3 commits into from
Nov 5, 2021
+26 −21
Merged

Release 2.1.0 into develop #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6476c0c
Bumped to version 2.1.0
AliSoftware Oct 22, 2021
fd1a15d
Extract common steps to install dependencies
AliSoftware Oct 22, 2021
a229cfa
Fix path to install-dependencies from gem-push
AliSoftware Oct 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .buildkite/gem-push.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
#!/bin/bash -eu

echo "--- :beer: Installing Dependencies"
brew bundle --file .buildkite/brewfile

echo "--- :rubygems: Setting up Gems"
install_gems
.buildkite/install-dependencies.sh

echo "--- :hammer: Build Gemspec"
gem build fastlane-plugin-wpmreleasetoolkit.gemspec
Expand Down
7 changes: 7 additions & 0 deletions .buildkite/install-dependencies.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
#!/bin/bash -eu

echo "--- :beer: Installing Dependencies"
brew bundle --file .buildkite/brewfile
Copy link
Contributor Author

@AliSoftware AliSoftware Oct 22, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this takes a bit of time to run on CI – especially since it's done by each separate step, as each one runs in a separate VM, so each step installs brew dependencies individually – and would benefit some caching.

That being said, caching brew installs, unlike other dependencies like gems or pods, has proven quite tricky and not always trivial, especially since it installs stuff system-wide, and not always all in a single location or folder we could cache. My past experience at trying to cache brew installs have often led to quirks, issues and instabilities (depending on the formulae installed and what they install and where on the system), which is why I didn't spend time on this yet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had trouble with that in the past, too.

I don't think it's a big issue for the moment, albeit it's admittedly "wasteful" to do that every time.

I wonder if it would be too much of a stretch to provision our VMs with those tools, since all the steps here run on those?


echo "--- :rubygems: Setting up Gems"
install_gems
12 changes: 3 additions & 9 deletions .buildkite/pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,7 @@ steps:
- label: "🧪 Build and Test"
key: "test"
command: |
echo "--- :beer: Installing Dependencies"
brew bundle --file .buildkite/brewfile

echo "--- :rubygems: Setting up Gems"
install_gems
.buildkite/install-dependencies.sh

echo "--- :hammer: Build DrawText"
bundle exec rake compile
Expand All @@ -36,8 +32,7 @@ steps:
#################
- label: "🧹 Lint"
command: |
echo "--- :rubygems: Setting up Gems"
install_gems
.buildkite/install-dependencies.sh

echo "--- :rubocop: Run Rubocop"
bundle exec rubocop
Expand All @@ -51,8 +46,7 @@ steps:
#################
- label: "⛔️ Danger"
command: |
echo "--- :rubygems: Setting up Gems"
install_gems
.buildkite/install-dependencies.sh

echo "--- :rubocop: Run Danger"
bundle exec danger
Expand Down
12 changes: 11 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,24 @@ _None_

### New Features

* Added a reminder mechanism for when you forgot a prompt was waiting for you in the Terminal. This reminder is [configurable via environment variables](https://github.com/wordpress-mobile/release-toolkit/blob/5c9b79db4bfcb298376fe3e81bc53881795922a5/lib/fastlane/plugin/wpmreleasetoolkit/helper/interactive_prompt_reminder.rb#L3-L22) to change the default delays and optionally opt-in for speaking a voice message in addition to the default beep + dock icon badge. [#302]
_None_

### Bug Fixes

_None_

### Internal Changes

_None_

## 2.1.0

### New Features

* Added a reminder mechanism for when you forgot a prompt was waiting for you in the Terminal. This reminder is [configurable via environment variables](https://github.com/wordpress-mobile/release-toolkit/blob/5c9b79db4bfcb298376fe3e81bc53881795922a5/lib/fastlane/plugin/wpmreleasetoolkit/helper/interactive_prompt_reminder.rb#L3-L22) to change the default delays and optionally opt-in for speaking a voice message in addition to the default beep + dock icon badge. [#302]

### Internal Changes

- Replace CircleCI and GitHub Actions with Buildkite

## 2.0.0
Expand Down
8 changes: 3 additions & 5 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: .
specs:
fastlane-plugin-wpmreleasetoolkit (2.0.0)
fastlane-plugin-wpmreleasetoolkit (2.1.0)
activesupport (~> 5)
bigdecimal (~> 1.4)
chroma (= 0.2.0)
Expand Down Expand Up @@ -267,7 +267,6 @@ GEM
method_source (0.9.2)
mini_magick (4.11.0)
mini_mime (1.1.2)
mini_portile2 (2.6.1)
minitest (5.14.4)
molinillo (0.8.0)
multi_json (1.15.0)
Expand All @@ -277,8 +276,7 @@ GEM
naturally (2.2.1)
netrc (0.11.0)
no_proxy_fix (0.1.2)
nokogiri (1.12.5)
mini_portile2 (~> 2.6.1)
nokogiri (1.12.5-x86_64-darwin)
racc (~> 1.4)
octokit (4.21.0)
faraday (>= 0.9)
Expand Down Expand Up @@ -426,4 +424,4 @@ DEPENDENCIES
yard

BUNDLED WITH
2.2.27
2.2.29
2 changes: 1 addition & 1 deletion lib/fastlane/plugin/wpmreleasetoolkit/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module Fastlane
module Wpmreleasetoolkit
VERSION = '2.0.0'
VERSION = '2.1.0'
end
end