Rename Linter helper in preparation for new upcoming actions #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this helper is only containing code related to the SwiftGen-based linter and is already quite large, so we shouldn't add more to it. I plan to put any other (upcoming) L10n-related helper methods (that I'll need for future actions around our L10n refactor project) in a separate helper, to avoid flooding this existing one with more stuff, hence renaming this one to a more ad-hoc name first in preparation.
AliSoftware
force-pushed
the
l10n/rename-linter-helper
branch
from
120f82e to
9425614
Compare
oguzkocer
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I decided to do individual PRs to make each step easier to review)
What
In preparation for the new actions to come to handle the various parts of the L10n project, this renames the
Ios::L10nHelpertoIos::L10nLinterHelper.Why
This is because this helper is currently only containing/focused on methods about our SwiftGen-based iOS
.stringsfile linter, and that helper is already quite large.It seems like a good thing to keep all that's related to the linter in a dedicated helper like that, but given I plan to need more helper methods for other L10n-related things as part of my L10n tooling modernization project, and didn't want to add those future new L10n-but-non-linter-related helper methods in the same file, this PR renames that helper to make it clear that it's L10n-Linter-specific, that way we will be able to create a brand new and different
Ios::L10nHelperfile for everything else I plan to add there.