App Size Metrics: add support for Android Universal APKs

[AliSoftware]

This work is part of the App Metrics project [ref: paaHJt-37V-p2] and implements the fastlane actions necessary to send iOS and Android app size metrics [ref: paaHJt-3od-p2#comment-6098] to the App Metrics server.

What

This builds on top of #364 and adds support for including "Universal APKs" metrics for Android.

(I suggest to get #364 merged first before this #365, to keep the diffs of each PR separate and easier to review in isolation)

Why

This will mostly be useful if/when we want to send app size metrics for Installable Builds, which are build using ./gradlew assemble<app>JalapenoDebug and thus produce a single, Universal .apk — as opposed to an .aab bundle like we do for beta and release builds that we upload to the Play Store)

How

• New universal_apk_path parameter for the android_send_app_size_metrics action
• The aab_path parameter is no longer mandatory, to allow the case where we only pass the universal APK but no .aab. It's still required to have at least one of universal_apk_path or aab_path (if not both) though.
• Changed a key used in the Android metrics payload to the more explicit "Optimized File Size" for R8-optimized APKs (i.e. file-size as reported by apkanalyzer, as opposed to the .apk file size on disk).
  • Hopefully that will help differentiate in particular the Universal APK's file size on disk vs the Universal APK's optimized file size ("optimized" as in "after R8 optimizations and according to apkanalyzer", as opposed to "optimized for a specific device architecture", that latter being instead indicated by the split: metadata)
• Moved the keys used in each metrics payload into constants at the top of the action, making them easier to spot and change

To Test

• Check that tests pass on this PR (CI green)
• Check [Tooling] Draft: Upload app metrics WordPress-Android#16580, which uses this branch to run the action with the Universal APKs built for WP and JP Installable Builds
  • Verify that CI is green on that WPAndroid PR
  • Verify that the *-app-size-metrics.json files in the "Artifacts" tab of the WPAndroid PR's CircleCI job look as expected.

[mokagio]

👍

[mokagio]

Just curious: Why is at "pseudo-name"?

[AliSoftware]

Because for all the other splits, the name (i.e. the value used for the split: metadata) is provided by bundletool (it's the basename of the .apk produced by it in the <tmpdir>/splits/*.apk); while for the universal APK it's just a name of our choosing and not some official name provided by the Android tooling, so it could be any name we want it to be.

In fact if we wanted to be pedantic, the Universal APK should probably not be considered a "split" per se — it's not the name of a CPU architecture after all. So it's a bit like if we said for iOS that the Universal .ipa was a "thinned version for the device named 'Universal'": pseudo-name because not really the name of a split/CPU-arch but one we made up to represent/mean "multiple archs in a single FAT file".