Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated create_release in favor of create_github_release #588

Merged

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Sep 3, 2024

I was about to finalize 12.0.0 when I grepped for "depreacted" and realized a new deprecation landed on trunk while #580 was in progress.

Builds on top of
#585.

Those changes were merged just recently but their context was that of a minor update, unaware that trunk already included a breaking change.

Since we are breaking things, I'd say we might as well remove backward compatibility by forcing users that upgrade to 12.0.0 to rename create_release to create_github_release.

What does it do?

Checklist before requesting a review

  • Run bundle exec rubocop to test for code style violations and recommendations
  • Add Unit Tests (aka specs/*_spec.rb) if applicable - N.A.
  • Run bundle exec rspec to run the whole test suite and ensure all your tests pass
  • Make sure you added an entry in the CHANGELOG.md file to describe your changes under the appropriate existing ### subsection of the existing ## Trunk section.
  • If applicable, add an entry in the MIGRATION.md file to describe how the changes will affect the migration from the previous major version and what the clients will need to change and consider.

Build on top of
#585.

Those changes were merged just recently but their context was that of a
minor update, unaware that `trunk` already included a breaking change.

Since we are breaking things, I'd say we might as well remove backward
compatibility by forcing users that upgrade to 12.0.0 to rename
`create_release` to `create_github_release`.
@mokagio mokagio added this to the 12.0.0 milestone Sep 3, 2024
@mokagio mokagio enabled auto-merge September 3, 2024 06:26
Copy link
Contributor

@iangmaia iangmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given trunk already had breaking changes, makes sense to me 👍

@mokagio mokagio merged commit 282ab68 into trunk Sep 3, 2024
5 of 9 checks passed
@mokagio mokagio deleted the mokagio/remove-deprecated-create_github_release_action branch September 3, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants