Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file path issue in check_fonts_installed method #615

Merged
merged 4 commits into from
Nov 21, 2024

Conversation

irfano
Copy link
Member

@irfano irfano commented Nov 19, 2024

What does it do?

This fixes an issue with accessing a file in check_fonts_installed method. Before, calling this from WCAndroid resulted in the following error:

No such file or directory @ rb_sysopen - playstoreres/assets/style.css

Checklist before requesting a review

  • Run bundle exec rubocop to test for code style violations and recommendations
  • Add Unit Tests (aka specs/*_spec.rb) if applicable
  • Run bundle exec rspec to run the whole test suite and ensure all your tests pass
  • Make sure you added an entry in the CHANGELOG.md file to describe your changes under the appropriate existing ### subsection of the existing ## Trunk section.
  • If applicable, add an entry in the MIGRATION.md file to describe how the changes will affect the migration from the previous major version and what the clients will need to change and consider.

@irfano irfano added the bug Something isn't working label Nov 19, 2024
@irfano irfano requested a review from a team November 19, 2024 17:47
irfano and others added 2 commits November 20, 2024 20:16
@irfano irfano requested a review from AliSoftware November 20, 2024 17:19
@irfano
Copy link
Member Author

irfano commented Nov 20, 2024

@AliSoftware, could you help me choose the right milestone for this PR and #614? I want to include these fixes in the next WCAndroid and WCiOS releases.

@AliSoftware
Copy link
Contributor

Cc @iangmaia since I'm kinda afk today

  • I think we could remove the Danger rule about milestone in this repo as we don't really use them for this tooling repo
  • Can you make a new release so that @irfano can point to it in WC repos?

@AliSoftware AliSoftware merged commit 33a2ab5 into trunk Nov 21, 2024
7 checks passed
@AliSoftware AliSoftware deleted the fix/check-fonts-installed-method-for-screenshots branch November 21, 2024 11:24
@AliSoftware
Copy link
Contributor

I've prepared a new release in #616

@AliSoftware
Copy link
Contributor

@irfano Version 12.3.3 has now been released and published to RubyGems, so you should be able to update the reference in WC repos 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants