Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] Remove Danger check about GitHub milestone #617

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

AliSoftware
Copy link
Contributor

@AliSoftware AliSoftware commented Nov 21, 2024

Since we don't really use those in this repo that much

What does it do?

Checklist before requesting a review

  • Run bundle exec rubocop to test for code style violations and recommendations
  • Add Unit Tests (aka specs/*_spec.rb) if applicable N/A
  • Run bundle exec rspec to run the whole test suite and ensure all your tests pass N/A
  • Make sure you added an entry in the CHANGELOG.md file to describe your changes under the appropriate existing ### subsection of the existing ## Trunk section.
  • If applicable, add an entry in the MIGRATION.md file to describe how the changes will affect the migration from the previous major version and what the clients will need to change and consider. N/A

Since we don't really use those in this repo that much
@AliSoftware AliSoftware changed the title Remove Danger check about GitHub milestone [Internal] Remove Danger check about GitHub milestone Nov 21, 2024
@AliSoftware AliSoftware requested review from iangmaia and a team November 21, 2024 12:01
@AliSoftware AliSoftware self-assigned this Nov 21, 2024
Copy link
Contributor

@iangmaia iangmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AliSoftware AliSoftware merged commit a58fa54 into trunk Nov 22, 2024
5 of 9 checks passed
@AliSoftware AliSoftware deleted the tooling/danger branch November 22, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants