Fix _wait_removed completion on invalid object path #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmsilva-pg
approved these changes
Apr 25, 2024
pmessan
approved these changes
Apr 25, 2024
The _wait_removed method registers the "InterfacesRemoved" callback on the adapter path of the device without checking which object was removed when called. This means that any removed interface while a connection is being established can cause the _wait_removed to complete and cancel the connection. This commit simply checks that the callback is for the proper device object path. Fixes hbldh#1489
toni-proglove
approved these changes
Apr 25, 2024
arthur-proglove
force-pushed
the
proglove/fix/bluez_wait_removed
branch
from
6a0fe08 to
33ee805
Compare
arthur-proglove
merged commit 4b67703
into
workaroundgmbh:proglove-v0.21.1
1 check failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The _wait_removed method registers the "InterfacesRemoved" callback on the adapter path of the device without checking which object was removed when called.
This means that any removed interface while a connection is being established can cause the _wait_removed to complete and cancel the connection.
This commit simply checks that the callback is for the proper device object path.