Seperating Docker form Validator #151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Created a seperate file for docker, to perform docker specific tasks (like checking if docker is installed on the system). 2. Added two-way IPC channel for main and renderer to communicate the state of docker. Purpose of this PR is so that in the future we could use this approach to makes sure docker is setup in the host machine properly and communicate messages notifying the UI.
|
mmm, looks like we're clashing - in #149 I have started to pull the Docker related IPC into main/ipc/docker.ts, continuing to port to PromiseIPC and use dockerode. All I need to go back to #123, is to make a default |
|
I've merged the dockerode npm module work I did, there's lots more todo tho, if you want to add a better docker state IPC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
installed on the system).
Purpose of this PR is so that in the future we could use this approach to makes sure docker is setup
in the host machine properly and communicate messages notifying the UI.