Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AkkaPiObservable subscribes PiEventHandlers globally #7

Closed
PetrosPapapa opened this issue Oct 9, 2018 · 0 comments · Fixed by #27
Closed

AkkaPiObservable subscribes PiEventHandlers globally #7

PetrosPapapa opened this issue Oct 9, 2018 · 0 comments · Fixed by #27
Labels
bug Something isn't working low priority We are not in any rush to address this

Comments

@PetrosPapapa
Copy link
Member

AkkaPiObservable uses Akka's eventStream which is shared among all AkkaPiObservables (AkkaExecutors).

For example, if you subscribe a PrintEventHandler to one unit test, it will print all events from subsequent unit tests even though they use a separate AkkaExecutor.

This is ok for now, because we typically only use one AkkaExecutor at a time, but must be solved by using a custom Akka Stream.
@PetrosPapapa PetrosPapapa added the bug Something isn't working label Oct 9, 2018
PetrosPapapa added a commit that referenced this issue Oct 9, 2018
@PetrosPapapa
Bug fixed
147f777 
Feeling much better about the ProcessExecutor trait now. Quite a few
changes made to the implemented executors to make sure they comply.

MongoExecutor needs testing.

Introduced issue #7
@PetrosPapapa PetrosPapapa added the low priority We are not in any rush to address this label Nov 7, 2018
This was referenced Nov 21, 2018
Closed
Merged
PetrosPapapa added a commit that referenced this issue Nov 24, 2018
@PetrosPapapa
Merge pull request #27 from PetrosPapapa/petros/issue7simple
15327e5 
Fixes #7 using `SimplePiObservable`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working low priority We are not in any rush to address this
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #7 using SimplePiObservable workflowfm/pew
1 participant
@PetrosPapapa