Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up channel structure and involved code #63

Merged
merged 11 commits into from
Jan 8, 2021
Merged

Conversation

PetrosPapapa
Copy link
Member

This cleans up the channel structure and makes the separation between channels and string more concrete.

This is in preparation to deal with #59 which may require a better structure.

Implicit conversions still allow the use of strings in place of channels, so everything is backwards compatible.

This seems to have caused a fairly significant decrease in efficiency (Dyer-Simulation takes 50% more time), though it's not exactly clear why. Perhaps comparing a wrapper case class is so much worse than comparing a string directly? Either way, I expect a better substitution algorithm to help massively improve the efficiency compared to the loss incurred here.

This PR also improves scaladocs and unit tests for a few things like PiObjects.

@PetrosPapapa PetrosPapapa added the code improvement requires improvements in the code such as cleaning up or commenting/documentation label Jan 8, 2021
@PetrosPapapa PetrosPapapa self-assigned this Jan 8, 2021
@PetrosPapapa PetrosPapapa merged commit c842fc4 into master Jan 8, 2021
@PetrosPapapa PetrosPapapa deleted the cleanupChannels branch January 8, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code improvement requires improvements in the code such as cleaning up or commenting/documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant