Add DomainData to Organization create and update methods, replacing deprecated domains
#165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,5 +1,6 @@ | |||
| namespace WorkOS | |||
| { | |||
| using System; | |||
There was a problem hiding this comment.
What is this System used for?
There was a problem hiding this comment.
It was added in order to use ObsoleteAttribute which comes from the System namespace.
amadeo-workos
approved these changes
May 7, 2024
mthadley
deleted the
feature/auth-3095-net-add-domains_data-to-sdks-and-deprecate-domains
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new
DomainDataoption to be passed to Organization create and update calls, instead of theDomainsparameter which is being deprecated.Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.