add created_at and updated_at fields #118
Conversation
SDK-252 Add created_at and updated_at fields in Go SDK
Add these fields for the Connection, Directory, and Organization types |
pkg/directorysync/client.go
Outdated
| @@ -421,6 +421,12 @@ type Directory struct { | |||
|
|
|||
| // Identifier for the Directory's Organization. | |||
| OrganizationID string `json:"organization_id"` | |||
|
|
|||
| //Created At | |||
There was a problem hiding this comment.
Could we make these doc comments look more like this?
- Full sentences describing the field
- Space between the
//and the first word of the comment
| //Created At | |
| // The timestamp of when the Directory was created. |
pkg/organizations/client.go
Outdated
| @@ -68,6 +68,12 @@ type Organization struct { | |||
|
|
|||
| // The Organization's Domains. | |||
| Domains []OrganizationDomain `json:"domains"` | |||
|
|
|||
| //Created At | |||
There was a problem hiding this comment.
Similar to @maxdeviant's previous comment, we should update these comments (and the ones in pkg/sso/client.go).
After that, I think this will be good to go!
There was a problem hiding this comment.
Hopefully got it all :)
There was a problem hiding this comment.
Looks like there's just a few more for Organization in pkg/organizations/client.go.
There was a problem hiding this comment.
Brutal that I missed that but this is now updated in:
pkg/sso/client.go
pkg/organizations/client.go
pkg/directorysync/client.go
|
Just realized that some of the comments were referring to the wrong type. Left some suggestions that should fix it. Last thing, I think! |
Co-authored-by: Michael Hadley <ufomoe@gmail.com>
Co-authored-by: Michael Hadley <ufomoe@gmail.com>
Co-authored-by: Michael Hadley <ufomoe@gmail.com>
AshGodfrey
deleted the
feature/sdk-252-add-created_at-and-updated_at-fields-in
branch
Resolves SDK-252.
Added created_at and updated_at to organization, connection, and directory.