Fix list endpoints #236
Merged
Fix list endpoints #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattgd
approved these changes
Jun 20, 2024
Comment on lines
+28
to
+40
| val params = | ||
| (obj::class as KClass<T>).memberProperties.associate { prop: KProperty1<T, *> -> | ||
| prop.name.toSnakeCase() to | ||
| prop.get(obj)?.let { value -> | ||
| if (value::class.isData) { | ||
| toMap(value) | ||
| } else { | ||
| value.toString() | ||
| } | ||
| } | ||
| } | ||
|
|
||
| return params.filterValues { it != null } |
|
To be honest, I have no idea why those annotations are in there. I'd rather not remove them though till we understand why there were put there in the first place. |
PaulAsjes
added a commit
that referenced
this pull request
Jul 19, 2024
* User Management support (#212) * Add Beta SDKs section in README.md (#213) * Add Beta SDKs section in README.md * Nit/typo * Nit in section about Beta releases in the README.md (#214) * Nit in section about Beta releases in the README.md * Improvement to README.md * Update README.md * User Management support * Update version (#215) * Add Beta SDKs section in README.md (#213) * Add Beta SDKs section in README.md * Nit/typo * Nit in section about Beta releases in the README.md (#214) * Nit in section about Beta releases in the README.md * Improvement to README.md * Update README.md * Update version * Fix release script (Beta branch) (#217) * Add Beta SDKs section in README.md (#213) * Add Beta SDKs section in README.md * Nit/typo * Nit in section about Beta releases in the README.md (#214) * Nit in section about Beta releases in the README.md * Improvement to README.md * Update README.md * Fix typo in release script * Add organization membership events (#218) Add organization membership events. * Update beta version (#219) * Add events and API changes for invitations and Magic Auth (#221) * Add events and API changes for invitations and Magic Auth * Fix failing test * Rename event data * v3.1.0-beta.user-management3 (#222) * Add organization membership deactivate and reactivate API methods. (#226) * Bump to version 3.1.0-beta.user-management4. (#227) * Add methods and events for email verification and password reset (#228) * v3.1.0-beta.user-management5 (#229) * Add find invitation by token method (#230) * Fix list endpoints (#236) * Now correctly parsing data as params for GET requests * Value has to be a string * lol linting * 3.1.0-beta.user-management6 (#233) * `invitationCode` should be `invitationToken` (#237) --------- Co-authored-by: amadeo <165715960+amadeo-workos@users.noreply.github.com> Co-authored-by: Matt Dzwonczyk <9063128+mattgd@users.noreply.github.com> Co-authored-by: Blair Lunceford <74257063+blairlunceford@users.noreply.github.com> Co-authored-by: Michael Hadley <m@mthadley.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't be fooled by the line count, it's mostly my editor fixing spacing issues.
datagets passed into a request which is then used to form the request body. In the case of aGETthough there isn't a body, but there can be URL parameters. Data was being passed into list endpoints for UM, but because there is no body with aGETit was being ignored.This fixes that by parsing
dataas a map and using it as URL parameters for list requests.Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.