Add API changes for invitations and Magic Auth #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blairworkos
changed the title
tribble
approved these changes
May 3, 2024
Comment on lines
+647
to
+658
| context 'with valid payload' do | ||
| it 'creates a magic_auth' do | ||
| VCR.use_cassette 'user_management/create_magic_auth/valid' do | ||
| magic_auth = described_class.create_magic_auth( | ||
| email: 'test@workos.com', | ||
| ) | ||
|
|
||
| expect(magic_auth.id).to eq('magic_auth_01HWXVEWWSMR5HS8M6FBGMBJJ9') | ||
| expect(magic_auth.email).to eq('test@workos.com') | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
Do we generally test other variations? There is also a version of this method that accepts an invitation.
There was a problem hiding this comment.
Sometimes - testing is a bit spotty in the SDKs. The invitation_token is optional for this method, and it's only needed in a specific case: sign ups are turned off and there isn't already a user with the email.
I'll add a follow up item to add a test for that case. I need to get my dashboard in a specific state to do that test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds API changes to support sending your own emails for invitations and Magic Auth.
accept_invitation_urlto invitation object returned by APIget_magic_authandcreate_magic_authsend_magic_auth_codemethod in favor ofcreate_magic_authDocumentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.
https://github.com/workos/workos/pull/26691