Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AppleOAuth constants #306

Merged
merged 3 commits into from
Jul 15, 2024
Merged

Add AppleOAuth constants #306

merged 3 commits into from
Jul 15, 2024

Conversation

gcarvelli
Copy link
Contributor

Description

Add the AppleOAuth constant so SDK users can kick off login flows with Sign in with Apple.

Documentation

Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.

[ ] Yes

If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.

@gcarvelli gcarvelli self-assigned this Jun 12, 2024
@gcarvelli gcarvelli marked this pull request as ready for review June 17, 2024 15:34
@marianapraz
Copy link

Hi :) Are there any plans to merge this soon?

@gcarvelli gcarvelli merged commit fddbe12 into main Jul 15, 2024
4 checks passed
@gcarvelli gcarvelli deleted the gio/add-apple-oauth branch July 15, 2024 16:32
@gcarvelli gcarvelli mentioned this pull request Jul 15, 2024
@gcarvelli
Copy link
Contributor Author

@marianapraz This change is now released in workos-ruby@v5.3.0. Thanks for your patience!

@marianapraz
Copy link

@marianapraz This change is now released in workos-ruby@v5.3.0. Thanks for your patience!

Hi @gcarvelli, this is still not working unfortunately, since Apple was not added to the ALL list and so validation fails :)

@mthadley
Copy link
Contributor

mthadley commented Aug 9, 2024

@marianapraz Thanks for catching that! We just released v5.5.1 which should hopefully have that fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants