Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session helper class #328

Merged
merged 7 commits into from
Aug 28, 2024
Merged

Session helper class #328

merged 7 commits into from
Aug 28, 2024

Conversation

PaulAsjes
Copy link
Contributor

@PaulAsjes PaulAsjes commented Aug 23, 2024

Description

Adds session helpers akin to those over in Node.

Documentation

Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.

[x] Yes

If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.

@PaulAsjes PaulAsjes changed the title [WIP] Session helper class Session helper class Aug 27, 2024
@PaulAsjes PaulAsjes requested a review from jasonroelofs August 27, 2024 13:21
Gemfile Outdated Show resolved Hide resolved
Copy link
Contributor

@jasonroelofs jasonroelofs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though I'm not an expert on the explicit session sealing logic here, but the tests and code look to be well covered.

@PaulAsjes PaulAsjes merged commit f3b7bce into main Aug 28, 2024
4 checks passed
@PaulAsjes PaulAsjes deleted the feature/session-helper branch August 28, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants