Tolerate node-0.12 #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After some research: for iojs support I will wait on nodejs/node#493 and nodejs/node-gyp#564 to be merged and hopefully nothing else will be needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for the goingnative workshop. I went through it and learnt a lot; all with node-0.12.
Here is the patch that makes the exercise 'am i ready?' pass with node-0.12.
I had originally coded the exercise to tolerate iojs versions too... but there is more work to do with node-gyp.
Do you guys think we should detect iojs and call pangyp instead?
Or do we wait for things to settle?