Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use os.tmpdir() instead of os.tmpDir() #433

Merged
merged 1 commit into from
May 14, 2016
Merged

use os.tmpdir() instead of os.tmpDir() #433

merged 1 commit into from
May 14, 2016

Conversation

ChALkeR
Copy link
Contributor

@ChALkeR ChALkeR commented May 13, 2016

@martinheidegger
Copy link
Contributor

@ChALkeR Thank you for the PR. Is this backwards compatible (sadly the nodejs documentation isn't quite clear why tmpDir worked before?!

@ChALkeR
Copy link
Contributor Author

ChALkeR commented May 13, 2016

@martinheidegger Down to v0.9.9. It's not compatible with v0.8.x, but is there a reason to care for those?

The issue I linked to has relevant information:

tmpdir() was introduced as replacement 3 years ago in
nodejs/node@3fe6aba

@martinheidegger martinheidegger merged commit 0cc5142 into workshopper:master May 14, 2016
@martinheidegger
Copy link
Contributor

I guess 0.8.0 should be fine (those people can update their development environment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChALkeR @martinheidegger