Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/benchmark #54

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Feature/benchmark #54

merged 4 commits into from
Sep 12, 2024

Conversation

zacdezgeo
Copy link
Collaborator

What I Changed

  • Added benchmark tests for the /fields and /summary endpoints to evaluate the performance of the API with varying AOI sizes and field counts.
  • Created a dedicated fixture (setup_benchmark_env) for setting up environment variables required for the benchmark tests.
  • Skip benchmark in CI as they are slow

How I Did It

  • Created a new setup_benchmark_env fixture to set the necessary environment variables (e.g., BASE_URL, FIELDS_ENDPOINT, SUMMARY_ENDPOINT, and FIELD) for the benchmark tests.
  • Parametrized the benchmark tests (test_benchmark_summary_varying_aoi and test_benchmark_summary_aoi_10_varying_fields) to handle varying areas and field counts, respectively.

Other Notes

Closes #50

Output from python -m pytest tests/test_benchmark.py --benchmark-histogram=my_benchmark_results:
my_benchmark_results

@zacdezgeo zacdezgeo added the enhancement New feature or request label Sep 11, 2024
@zacdezgeo zacdezgeo self-assigned this Sep 11, 2024
Copy link
Collaborator

@vincentsarago vincentsarago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@zacdezgeo zacdezgeo merged commit f2fe8e2 into main Sep 12, 2024
2 checks passed
@zacdezgeo zacdezgeo deleted the feature/benchmark branch September 12, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API benchmarking
2 participants