Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused files and database configuration #63

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Remove unused files and database configuration #63

merged 1 commit into from
Sep 24, 2024

Conversation

zacdezgeo
Copy link
Collaborator

What I Changed

  • Remove database connection settings in download.sh as unecessary
  • Delete chunk_parquet.py file as unused and empty
  • Remove deploy.md as more complete documentation is in docs/acceptance/db.md

How to test it

Not necessary, but run download.sh having your WB S3 env variables configured.

@zacdezgeo zacdezgeo added the documentation Improvements or additions to documentation label Sep 19, 2024
@zacdezgeo zacdezgeo requested a review from alukach September 19, 2024 16:22
@zacdezgeo zacdezgeo self-assigned this Sep 19, 2024
@alukach alukach merged commit 056f685 into main Sep 24, 2024
2 checks passed
@zacdezgeo zacdezgeo deleted the fix/db branch October 8, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alukach alukach Awaiting requested review from alukach

Assignees

@zacdezgeo zacdezgeo

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zacdezgeo @alukach