generated from worldbank/template
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/58/h3 parent approach #69
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Must still resolve Multipolygon support
vincentsarago
approved these changes
Sep 27, 2024
Andres notebook raised the initial bug for the small geometries. The notebook reproduced the issue and now demonstrates the fix.
alukach
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I Changed
_find_touches
function to identify H3 hexagon IDs that intersect with the boundary of the polygon defined by the AOI GeoJSON and include neighboring hexagons._recursive_polyfill
method to handle cases where no H3 IDs are returned, allowing it to continue to higher resolutions until a valid result is found.within
andtouches
.How to Test It
test_h3_utils.py
generate_h3_ids
function with various Polygon GeoJSON inputs to ensure that H3 IDs are generated correctly for different geographic shapes._find_touches
function.Quick example running with the
touches
keyword:Other Notes