-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata #72
Metadata #72
Conversation
@andresfchamorro, feel free to update the description or add comments here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great @andresfchamorro! The only change requested is moving the folder to a better location.
I see three points where the metadata could come into play:
- Letting a user browse the metadata and understand the dataset better - could be accomplished via a copy to the STAC browser. It would require that the copy be updated regularly. I tried using the GitHub repo file link directly and got a CORS error.
- Retrieving fields—After discussing this with @alukach, I propose we continue relying on the database directly to retrieve the available list of fields.
- Ensure consistency between metadata and data upon ingestion (Add checks to ensure data and metadata are in sync upon ingestion #73) - We should add some checks to avoid any drift between the metadata and underlying data in the database. This would make two more sensible.
@andresfchamorro @alukach; just need a ✅ to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zacharyDez Did you make these changes manually, or can you update the notebook so that we don't recreate it in the future without these changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow the content on catalog description and purpose got trimmed too...
ok i think i fixed what I mentioned in the comments so I will merge now :) also copied it to gh-pages so we can view it here: https://radiantearth.github.io/stac-browser/#/external/worldbank.github.io/DECAT_Space2Stats/stac/catalog.json?.language=en |
What's changed
catalog.json
,sources.json
, andspace2stats.json
.metadata.ipynb
) to handle metadata generation for Space2Stats.How to test it
metadata.ipynb
notebook and run the cells to generate the STAC catalog.stac
folder for completeness and accuracy.stac-check
on the generated STAC catalog to verify metadata compliance.Other Notes