Fix code scanning alert no. 2: Incomplete string escaping or encoding #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/worldbank/DHIS2-Downloader/security/code-scanning/2
To fix the problem, we need to ensure that both double quotes and backslashes are properly escaped in the CSV output. This can be achieved by first escaping backslashes and then escaping double quotes. The order of escaping is important to avoid double-escaping backslashes.
The best way to fix this is to update the
objectToCsvfunction to use a regular expression that handles both backslashes and double quotes. We will replace the currentreplacecall with a more comprehensive one that escapes both characters.Suggested fixes powered by Copilot Autofix. Review carefully before merging.