Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge main into DEV #77

Merged
merged 50 commits into from
Dec 19, 2024
Merged

merge main into DEV #77

merged 50 commits into from
Dec 19, 2024

Conversation

giorgiacek
Copy link
Contributor

Prework

Related GitHub issues and pull requests

  • Ref: #

Summary

Please explain the purpose and scope of your contribution.

We need to bring DEV up to main.

randrescastaneda and others added 30 commits July 5, 2023 22:08
@randrescastaneda
Merge pull request #66 from worldbank/DEV
e0b40dc 
Everything looks good. Thanks.
@tonyfujs
initial function to build requests using httr2
9f23350
@tonyfujs
replace all references to httr with httr2
356aced
@tonyfujs
adjust unit test suite and fix a few issues
88c8e2d
@tonyfujs
add documentation
e5a0a22
@tonyfujs
add httr2 and R minimum version to support native pipe
80c5bec
@tonyfujs
fix documentation
23fc955
@tonyfujs
disable ad-hoc caching (to be replaced with httr2 cache mechanism)
8eff3da
@tonyfujs
Add automatic retry to handle throttling
104f887
@tonyfujs
add response caching
b22f8c7
@tonyfujs
disable httr2 cache. Not working as expected
8d14b16
@tonyfujs
add back caching with new mechanism to handle cache path
6c897f5
@tonyfujs
Increment version number to 1.1.0
c767e48
@tonyfujs
add helper functions to deal with cache
3130a4d
@tonyfujs
make arrow default format
31e364c
@giorgiacek
check() passed
fa1af89
@giorgiacek
# PR 63 added, check() passed
ddee18b
@giorgiacek
new function get_grouped_stats() and support build_request_v2()
7638f4c
@giorgiacek
changes proposed
668e7d2
@giorgiacek
last changes (estimate instead of endpoint, pivoted result).
82859fa
@giorgiacek
changed name to get_gd(), check() passed
7769f4a
@giorgiacek
some typos corrected
c219985
@giorgiacek
popshare added back to grouped-stats
086df66
@giorgiacek
final get_cp() draft, no tests
e061e18
@giorgiacek
draft get-gd
558c85e
@giorgiacek
examples added to get_gd and lorenz parameter added back, not tested,…
60da6d7 
… waiting for pipapi to be updated
@giorgiacek
get_gd() vignette draft (not tested as api not working yet but should…
e0b92d0 
… work fine).
@giorgiacek
cp actually needs a default value
77c3b3c
@giorgiacek
use cases added to get-gd draft
c918bbf
@giorgiacek
typo corrected in get_gd, get_cp examples changes and default measure…
e6d6a3e 
…s changed too.
giorgiacek and others added 20 commits November 15, 2024 11:47
@giorgiacek
new datasets to test gd data, gd data vignette
5acca6d
@giorgiacek
get_gd some changes + full coverage with tests for get_gd()
0cd973f
@giorgiacek
get_cp() and get_cp_ki() with vignette done
884c4af
@giorgiacek
get_cp() tests done, coverage 100%
b288fff
@giorgiacek
minor adjustment and full coverage
7e8f553
@giorgiacek
full coverage and check() passed
9dc23cf
@giorgiacek
skipped one test for json (check) and added nowcast test
98676be
@giorgiacek
get_stats() when empty with json returns a different format than othe…
a819439 
…r, skipping a test
@giorgiacek
removed server = 'dev' and server = 'qa'. Check() passed.
ba96a0a
@randrescastaneda
export get_gd()
9faa22a
@randrescastaneda
Merge remote-tracking branch 'origin/httr2_gc_2' into httr2_gc_2
cde5f0d
@randrescastaneda
fix bug in get_gd
63b4929
@giorgiacek
small change to get_gd() test
0aa1a1a
@giorgiacek
typos in the vignettes corrected.
e94f4d8
@randrescastaneda
small update
fed4d4b
@randrescastaneda
fix legend in chart
e451617
@randrescastaneda
Merge pull request #75 from worldbank/httr2_gc_2
eee99de 
fixes to httr2, new endpoints, nowcast, attempt 2
@randrescastaneda
add Giorgia as author
5defab9
@giorgiacek
server = 'dev' typo corrected
cf3e853
@giorgiacek
Merge pull request #76 from worldbank/typo
57f18ce 
server = 'dev' typo corrected
@giorgiacek giorgiacek merged commit 72234cd into DEV Dec 19, 2024
0 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randrescastaneda randrescastaneda Awaiting requested review from randrescastaneda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giorgiacek @randrescastaneda @tonyfujs