Adds popshare option #19
Conversation
Web Scrapping coverage + draft clean up
Censors regional estimates given coverage
Set values to missing instead of deleting.
draft
povcalnet.ado
Outdated
| *---------- Poverty line/population share | ||
| if ("`popshare'" != ""){ | ||
| if ("`povline'" != ""){ | ||
| oi disp as err "povline and popshare cannot be used at the same time" |
There was a problem hiding this comment.
I Think this should be noi rather than oi
There was a problem hiding this comment.
Awful typo, I'll fix it right away
povcalnet.ado
Outdated
| loc pcall = "popshare" | ||
| } | ||
| } | ||
| else if ("`povline'" == "") { |
There was a problem hiding this comment.
This condition is not mutually exclusive with the first condition and with the else statement. I think the problem is that these lines,
if ("`popshare'" != ""){
if ("`povline'" != ""){Should be just one line
There was a problem hiding this comment.
Agree, I'll adjust it
|
Hi Davdi, one more thing. It is still not working with several values in popshare. For instance, it is not working like this, povcalnet, popshare(.2 .5) clear
povcalnet, popshare(.2 .5) clear fillgapsHowever, I am not worry about it. We could create a loop and make the query. It is not a big deal. Thanks. |
draft
|
Hi Andres, All fixed and rebased to ease the merge. Let me know if something is missing. Thanks ! |
|
Perfect. All changes have been added. |
No description provided.