Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove reducedness checks #128

Merged
merged 1 commit into from
Sep 11, 2023
Merged

remove reducedness checks #128

merged 1 commit into from
Sep 11, 2023

Conversation

dcbuild3r
Copy link
Collaborator

Now semaphore-mtb checks that the preRoot, postRoot, and idComms are in reduced element form ( < SNARK_SCALAR_FIELD), therefore we can remove the checks within the smart contract for all of those to save on gas costs.

@dcbuild3r dcbuild3r added the enhancement New feature or request label Sep 8, 2023
@dcbuild3r dcbuild3r self-assigned this Sep 8, 2023
@dcbuild3r dcbuild3r merged commit 2c32398 into main Sep 11, 2023
1 check passed
@dcbuild3r dcbuild3r deleted the dcbuild3r/remove-reducedness-checks branch September 11, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xKitsune 0xKitsune 0xKitsune approved these changes

@kustosz kustosz Awaiting requested review from kustosz

Assignees

@dcbuild3r dcbuild3r

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcbuild3r @0xKitsune