move struct TokensRecieved{} from Child to Library #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated TokenBase.sol import for `{Base}` to fix some compilation errors
wormhole-solidity-sdk refactored with initializers instead of constructors. changes => immutable states => public state
addressToBytes32CCTP() is basically same as toWormholeFormat() removed the function addressToBytes32CCTP() from the abstract child to utils , and made so it calls the other same function toWormholeFormat() instead of reformatting it seperately
|
Test file for CCTPAndTokenBase is now pushed for quick test . |
|
Nevermind , test case not setup properly... found the error , it seems error in the relayer testcase setup |
|
Ah it seems the error is still there , now I am sure it is issue with the relayer testcase |
move struct TokenReceived from child contracts to a library as it was adding to contract size of parent
|
The initialisable sdk is removed from the pull request instead I have pushed a possible improvement regarding a struct in child contracts TokenBase and CCTPandTokenBase |
BOBseal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wormhole Solidity SDK refactored without constructors for use in Nebula Bridge Contracts.
Changes => Immutable States are now Public states to allow changes through internal Initializers
edit: further changes if any is done will be pushed to same forked repo for any development done for Nebula Bridge