sdk/js: catch-all catch blocks swallow exceptions

[kcsongor]

Description and context

In several places, such as integration tests

wormhole/sdk/js/src/token_bridge/__tests__/aptos-integration.ts

Lines 108 to 112 in b09a644

	try {
	await createWrappedOnEth(ethTokenBridge, recipient, attestVAA);
	} catch (e) {
	// this could fail because the token is already attested (in an unclean env)
	}

but even in core sdk functions

wormhole/sdk/js/src/nft_bridge/getIsTransferCompleted.ts

Lines 55 to 58 in b09a644

	} catch (e: any) {
	// redeemed if the VAA was already executed
	return e.response.data.message.includes("VaaAlreadyExecuted");
	}

the catch blocks just swallow the exceptions. This is in most cases anticipating a specific exception, so the catch block should just check for that, and rethrow in any other case.

A good example of a catch block that does the correct thing is

wormhole/sdk/js/src/token_bridge/getIsTransferCompleted.ts

Lines 72 to 79 in b09a644

	} catch (e: any) {
	// redeemed if the VAA was already executed
	if (e.response.data.message.includes("VaaAlreadyExecuted")) {
	return true;
	} else {
	throw e;
	}
	}

Definition of done

No catch-all catch blocks in the sdk.

[AlberErre]

Happy to help with this 👀 @kcsongor

could you assign me the issue? 🏄‍♂️

[ritvij14]

@AlberErre are you still working on this or can I take it up?

[AlberErre]

Hey @ritvij14 feel free to pick this up 👍, I think @kcsongor could assign you the issue 👀

[ritvij14]

@kcsongor could you please assign the issue to me, I will get started on it

[Abhishekkochar]

@kcsongor If no-one is actively working on this. I can pick this up from here. Cheers

[kcsongor]

hey @Abhishekkochar, thanks! I don't believe anyone's actively working on this, so I'll assign the issue to you if you're interested in giving it a go

[Abhishekkochar]

@kcsongor double checking, are non-org people allowed to contribute? Currently getting error 403 when pushing the branch. I have already check the credentials. Thanks heaps.

[kcsongor]

You might have to fork the repo and push the branch to your own fork, then open a PR from there!