sdk/js: handling valid exceptions #3590
Conversation
Signed-off-by: Abhishekkochar <abhishekkochar2@gmail.com>
Abhishekkochar
requested review from
evan-gray,
kev1n-peters and
barnjamin
as code owners
|
@kcsongor, Please have a look. |
| @@ -127,7 +127,11 @@ describe("Algorand tests", () => { | |||
| vaaBytes | |||
| ); | |||
| } catch (e) { | |||
| success = false; | |||
| if(e instanceof Error && e.message.includes("wrapped asset already exists")){ | |||
| success = true; | |||
There was a problem hiding this comment.
shouldn't this be the other way around?
There was a problem hiding this comment.
Oh yes. Fixed. Will push soon.
| success = false; | ||
| //@notice | ||
| if(e instanceof Error && e.message.includes("wrapped asset already exists")){ | ||
| success = true; |
| @@ -420,6 +425,11 @@ describe("Aptos SDK tests", () => { | |||
| await createWrappedOnEth(ethTokenBridge, recipient, attestVAA); | |||
| } catch (e) { | |||
| // this could fail because the token is already attested (in an unclean env) | |||
| if(e instanceof Error && e.message.includes("wrapped asset already exists")){ | |||
There was a problem hiding this comment.
does the error message actually look like this?
|
@kcsongor, Can you please confirm if this is correct algogrand/package? |
I have tried to run them. There is an error when running alogrand tests? |
|
This error case is only hit when the tests are run a second time on an existing tilt instance. This never happens in CI and is only a hinderance to a developer trying to run the tests without cycling the corresponding chains. Given that the subsequent test cannot pass if the token was not properly attested, the existing code is adequate for CI. So, for the benefit of devs in this repo, it seems a more prudent thing would be to skip the test step altogether if the token was already attested. |
fix: #3190