Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: Fix issue where transfers that were loaded from the DB did not add a flow-cancel transfer on the TargetChain #4002

Merged
merged 5 commits into from
Jul 3, 2024
Merged

node: Fix issue where transfers that were loaded from the DB did not add a flow-cancel transfer on the TargetChain #4002

merged 5 commits into from
Jul 3, 2024

Commits on Jul 2, 2024

  1. node: Fix issue where transfers that were loaded from the DB did not add 

    a flow-cancel transfer on the TargetChain

Flow-canceling is done in the `ProcessMsgForTime` loop when a new
message occurs. However, this was not done when a node restarted and
reloaded transfers from the past 24 hours. As a result it was possible
for the node to calculate a result that showed that the outgoing
transfers for an emitter chain exceeded the daily limit. In effect this
is true but only with the condition that there was incoming flow to
allow this to happen. This appeared to violate an invariant and so the
node did not start properly.
    @johnsaigle
    johnsaigle committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    d25006f View commit details
    Browse the repository at this point in the history

  2. node: Add unit tests when reloading flow cancel transactions from the 

    database
    @johnsaigle
    johnsaigle committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    22218e1 View commit details
    Browse the repository at this point in the history

  3. node: fix lint errors in governor_test.go

    @johnsaigle
    johnsaigle committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    65e6213 View commit details
    Browse the repository at this point in the history

  4. node: fix function comments in governor_db.go

    @johnsaigle
    johnsaigle committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    003e5c8 View commit details
    Browse the repository at this point in the history

  5. node: change timestamp value; fix typos

    @johnsaigle
    johnsaigle committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    13d7dc6 View commit details
    Browse the repository at this point in the history