[v0.2.x] Handle not working when no items on init #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If item has no handle, then the whole item is draggable
gdebrauwer
deleted the
feature/handle-not-working-when-no-items-on-init-in-livewirev2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using multiple sortable groups, the handle identifier can always be set. If Sortablejs does not find a handle in an item, then the complete item will be draggable.
When using only one group and the group is empty on the initial livewire component load, then every item will be completely draggable. To fix that, we need to listen for component updates and only set the 'handle' option if we detect an item that has a handle.