Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add token revokal as post action #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

danielefranceschi
Copy link

@danielefranceschi danielefranceschi commented Sep 29, 2023

Description

Add token revokal, as found in @actions/create-github-app-token.

Motivation and Context

The change is mostly a preventive change, as it's not clear if there are count limits/TTL on the issued apptokens. Nevertheless, cleaning up what the action does is always a good idea.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (changes that improvement of current feature or performance)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I performed manual tests.

Notes

Also added the dist subdir, which can be deleted depending on your release workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant